Issue 6057002: Disable 'create shortcut' in newtab apps pulldown menu.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6057002: Disable 'create shortcut' in newtab apps pulldown menu. (Closed)

Created:
10 years ago by kochi

Modified:
9 years, 7 months ago

Reviewers:
arv (Not doing code reviews), satorux1

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/chrome/browser

Visibility:
Public.

Description

Disable 'create shortcut' in newtab apps pulldown menu. BUG=chromium-os:10364 TEST=manually check if pulldown menu of apps on newtab page doesn't have 'create shortcut' menu. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69699

Patch Set 1 #

Patch Set 2 : Also hide <hr> #

Total comments: 2

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
M	chrome/browser/dom_ui/app_launcher_handler.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/new_new_tab.html	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/ntp/apps.js	View	1	1 chunk	+1 line, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

arv (Not doing code reviews)

http://codereview.chromium.org/6057002/diff/2001/chrome/browser/resources/ntp/apps.js File chrome/browser/resources/ntp/apps.js (right): http://codereview.chromium.org/6057002/diff/2001/chrome/browser/resources/ntp/apps.js#newcode39 chrome/browser/resources/ntp/apps.js:39: (data.disableCreateAppShortcut ? 'none' : 'inline'); This looks wrong. The ...

10 years ago (2010-12-20 19:01:08 UTC) #3

kochi

10 years ago (2010-12-21 06:09:33 UTC) #4

http://codereview.chromium.org/6057002/diff/2001/chrome/browser/resources/ntp...
File chrome/browser/resources/ntp/apps.js (right):

http://codereview.chromium.org/6057002/diff/2001/chrome/browser/resources/ntp...
chrome/browser/resources/ntp/apps.js:39: (data.disableCreateAppShortcut ? 'none'
: 'inline');
On 2010/12/20 19:01:08, arv wrote:
> This looks wrong. The display of these should never be inline.

Good catch!
I created a follow-up CL at
http://codereview.chromium.org/6060003/

Could you review?

Expand Messages | Collapse Messages