Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6056008: Move lots of GMock stuff out of line. (Closed)

Created:
9 years, 11 months ago by Elliot Glaysher
Modified:
9 years, 7 months ago
CC:
chromium-reviews, vrk (LEFT CHROMIUM), ncarter (slow), sjl, Alpha Left Google, idana, Raghu Simha, ddorwin+watch_chromium.org, apatrick_chromium, acolwell GONE FROM CHROMIUM, annacc, pam+watch_chromium.org, awong, Paweł Hajdan Jr., darin-cc_chromium.org, tim (not reviewing)
Visibility:
Public.

Description

Move lots of GMock stuff out of line. Nico did some treemapping of our build time on Mac, and (surprise!) gmock unittests dominated. Gmock works with several large, heavy templates, and previous patches that out of line the ctors/dtors have significantly sped up compilation (e.g.GLMock) and have reduced thrashing. Nico says I should plug this again: http://www.chromium.org/developers/coding-style/cpp-dos-and-donts BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70516

Patch Set 1 #

Patch Set 2 : Copyright junk #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+431 lines, -149 lines) Patch
M chrome/browser/policy/device_management_backend_mock.h View 4 chunks +10 lines, -1 line 1 comment Download
A chrome/browser/policy/device_management_backend_mock.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M chrome/browser/prefs/pref_observer_mock.h View 3 chunks +4 lines, -10 lines 0 comments Download
A chrome/browser/prefs/pref_observer_mock.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M chrome/browser/prefs/pref_service_mock_builder.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/prefs/pref_service_mock_builder.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/sync/engine/read_node_mock.h View 3 chunks +4 lines, -2 lines 1 comment Download
M chrome/browser/sync/glue/change_processor_mock.h View 2 chunks +3 lines, -2 lines 0 comments Download
A chrome/browser/sync/glue/change_processor_mock.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/data_type_controller_mock.h View 2 chunks +4 lines, -1 line 0 comments Download
A chrome/browser/sync/glue/data_type_controller_mock.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/data_type_manager_mock.h View 2 chunks +3 lines, -12 lines 0 comments Download
A chrome/browser/sync/glue/data_type_manager_mock.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_mock.h View 2 chunks +3 lines, -15 lines 0 comments Download
A chrome/browser/sync/glue/sync_backend_host_mock.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M chrome/browser/sync/profile_sync_factory_mock.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_factory_mock.cc View 1 3 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_mock.h View 2 chunks +3 lines, -3 lines 0 comments Download
A chrome/browser/sync/profile_sync_service_mock.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 10 chunks +13 lines, -4 lines 0 comments Download
M chrome/common/notification_observer_mock.h View 2 chunks +3 lines, -3 lines 0 comments Download
A chrome/common/notification_observer_mock.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/common/pref_store_observer_mock.h View 2 chunks +3 lines, -3 lines 0 comments Download
A chrome/common/pref_store_observer_mock.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/test/profile_mock.h View 2 chunks +4 lines, -1 line 0 comments Download
A chrome/test/profile_mock.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/command_buffer_mock.h View 2 chunks +3 lines, -7 lines 0 comments Download
A gpu/command_buffer/common/command_buffer_mock.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/mocks.h View 4 chunks +7 lines, -14 lines 0 comments Download
A gpu/command_buffer/service/mocks.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M gpu/gpu.gyp View 1 5 chunks +5 lines, -3 lines 1 comment Download
M media/base/mock_filter_host.h View 2 chunks +3 lines, -2 lines 0 comments Download
A media/base/mock_filter_host.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M media/base/mock_filters.h View 1 19 chunks +21 lines, -43 lines 0 comments Download
M media/base/mock_filters.cc View 1 2 chunks +63 lines, -1 line 0 comments Download
M media/base/mock_task.h View 2 chunks +5 lines, -12 lines 0 comments Download
A media/base/mock_task.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M media/media.gyp View 1 5 chunks +10 lines, -4 lines 0 comments Download
M webkit/tools/test_shell/test_shell.gypi View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Elliot Glaysher
Speedup gains are minimal (10s of seconds on a -j8 build of unit_tests gpu_tests). Mainly ...
9 years, 11 months ago (2011-01-04 23:41:52 UTC) #1
Nico
LG might be nice to link to your c++ best practices doc in the CL ...
9 years, 11 months ago (2011-01-05 01:14:13 UTC) #2
scherkus (not reviewing)
9 years, 11 months ago (2011-01-05 01:38:37 UTC) #3 
drive by... LGTM on media stuff

Powered by Google App Engine
This is Rietveld 408576698