Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 6056007: net: Add namespace net to the remaining files under url_request directory. (Closed)

Created:
9 years, 11 months ago by tfarina
Modified:
9 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, michaeln, amit, Paweł Hajdan Jr., jam, kinuko, pam+watch_chromium.org, brettw-cc_chromium.org, stuartmorgan+watch_chromium.org, Erik does not do reviews, Aaron Boodman, Ilya Sherman, dhollowa, nkostylev+cc_chromium.org, Alpha Left Google, garykac, tim (not reviewing), Raghu Simha, ncarter (slow), awong, James Hawkins, Sergey Ulanov, idana, dmac, davemoore+watch_chromium.org
Visibility:
Public.

Description

net: Add namespace net to the remaining files under url_request directory. It just adds the 'namespace net' to these files and a typedef for them, because there are many entries to fix in one pass. They will be fixed later. BUG=64263 TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70592

Patch Set 1 : #

Total comments: 2

Patch Set 2 : wtc review #

Patch Set 3 : fix win trybot #

Patch Set 4 : more win fixes #

Patch Set 5 : fix the bots? #

Patch Set 6 : one more win fix #

Patch Set 7 : #

Patch Set 8 : gaia fix #

Patch Set 9 : gaia2 fix #

Patch Set 10 : webkit fix #

Patch Set 11 : io_thread fix #

Patch Set 12 : google fix #

Patch Set 13 : net fix #

Patch Set 14 : chrome_frame fix #

Patch Set 15 : webkit fix #

Patch Set 16 : autocomplete fix #

Patch Set 17 : more browser fixes #

Patch Set 18 : fix everything for real now? #

Patch Set 19 : now with URLRequestContext #

Patch Set 20 : even more fixes #

Patch Set 21 : nothing to say #

Patch Set 22 : chromeos fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+485 lines, -399 lines) Patch
M chrome/browser/alternate_nav_url_fetcher.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/appcache/appcache_dispatcher_host.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 4 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/autocomplete/search_provider.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/autofill_download.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/autofill/autofill_download.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +7 lines, -6 lines 0 comments Download
M chrome/browser/automation/url_request_automation_job.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_plugin_browsing_context.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 4 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/chrome_plugin_browsing_context.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/apply_services_customization.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/apply_services_customization.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/cookie_fetcher.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/image_downloader.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/image_downloader.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/mock_auth_response_handler.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/user_image_downloader.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/user_image_downloader.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +7 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_updater.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/file_system/file_system_dispatcher_host.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/geolocation/network_location_request.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/google/google_url_tracker.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/toolbar_importer.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/importer/toolbar_importer.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/intranet_redirect_detector.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/io_thread.h View 1 2 3 4 5 6 7 8 9 10 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/metrics/metrics_service.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/net/chrome_url_request_context.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/net/connection_tester.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 4 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/net/sdch_dictionary_fetcher.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/net/websocket_experiment/websocket_experiment_task.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/net/websocket_experiment/websocket_experiment_task.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugin_download_helper.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/plugin_download_helper.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/plugin_service.h View 1 2 3 4 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/policy/device_management_service.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/remoting/directory_add_request.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/async_resource_handler.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/buffered_resource_handler.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/cross_site_resource_handler.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/download_resource_handler.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/download_throttling_resource_handler.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/offline_resource_handler.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/redirect_to_file_resource_handler.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/resource_dispatcher_host.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 4 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/renderer_host/resource_handler.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/renderer_host/resource_message_filter.h View 1 2 3 4 5 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/resource_request_details.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/safe_browsing_resource_handler.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/save_file_resource_handler.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/socket_stream_dispatcher_host.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/socket_stream_host.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/renderer_host/sync_resource_handler.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/x509_user_cert_resource_handler.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_service.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 5 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/safe_browsing/protocol_manager.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/speech/speech_recognition_request.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/spellcheck_host.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/spellcheck_host.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/http_bridge.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 6 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/task_manager/task_manager.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/translate/translate_manager.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/common_param_traits.h View 1 2 3 4 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/extension_localization_peer.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/common/net/gaia/gaia_auth_fetcher.h View 1 2 3 4 5 6 7 8 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/common/net/url_fetcher.h View 1 2 3 4 5 6 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/net/url_request_context_getter.h View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/resource_dispatcher.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/security_filter_peer.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 5 chunks +7 lines, -8 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_url_fetcher.h View 1 2 3 4 5 6 4 chunks +12 lines, -8 lines 0 comments Download
M chrome/service/gaia/service_gaia_authenticator.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/gaia/service_gaia_authenticator.cc View 1 2 3 4 5 6 7 1 chunk +6 lines, -3 lines 0 comments Download
M chrome/service/net/service_url_request_context.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/automation/automation_proxy_uitest.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/test/test_url_request_context_getter.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 3 chunks +4 lines, -3 lines 0 comments Download
M chrome_frame/cfproxy.h View 1 2 3 4 3 chunks +5 lines, -2 lines 0 comments Download
M chrome_frame/chrome_frame_automation.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +3 lines, -2 lines 0 comments Download
M chrome_frame/chrome_frame_delegate.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +4 lines, -2 lines 0 comments Download
M chrome_frame/external_tab.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +6 lines, -5 lines 0 comments Download
M chrome_frame/npapi_url_request.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +3 lines, -2 lines 0 comments Download
M chrome_frame/plugin_url_request.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 3 chunks +3 lines, -3 lines 0 comments Download
M chrome_frame/test/automation_client_mock.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 4 chunks +5 lines, -6 lines 0 comments Download
M chrome_frame/urlmon_url_request.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +3 lines, -2 lines 0 comments Download
M chrome_frame/urlmon_url_request_private.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 5 chunks +9 lines, -9 lines 0 comments Download
M net/ocsp/nss_ocsp.h View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M net/proxy/proxy_script_fetcher.h View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M net/proxy/proxy_script_fetcher_impl.h View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M net/proxy/proxy_service.h View 1 2 3 chunks +2 lines, -2 lines 0 comments Download
M net/socket_stream/socket_stream_job.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/https_prober.h View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +5 lines, -3 lines 0 comments Download
M net/url_request/url_request.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 6 chunks +13 lines, -14 lines 0 comments Download
M net/url_request/url_request_context.h View 5 chunks +44 lines, -40 lines 0 comments Download
M net/url_request/url_request_context.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M net/url_request/url_request_ftp_job.h View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M net/url_request/url_request_http_job.h View 1 2 3 4 2 chunks +2 lines, -3 lines 0 comments Download
M net/url_request/url_request_job.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 5 chunks +6 lines, -6 lines 0 comments Download
M net/url_request/url_request_job_tracker.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +2 lines, -2 lines 0 comments Download
M net/url_request/url_request_status.h View 3 chunks +8 lines, -1 line 0 comments Download
M net/url_request/url_request_test_job.h View 6 chunks +18 lines, -11 lines 0 comments Download
M net/url_request/url_request_test_job.cc View 1 11 chunks +24 lines, -20 lines 0 comments Download
M net/url_request/view_cache_helper.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 5 chunks +17 lines, -11 lines 0 comments Download
M net/websockets/websocket.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 4 chunks +4 lines, -4 lines 0 comments Download
M webkit/appcache/appcache_service.h View 1 2 3 4 4 chunks +8 lines, -4 lines 0 comments Download
M webkit/fileapi/file_system_operation.h View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/fileapi/sandboxed_file_system_operation.h View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/glue/resource_loader_bridge.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/simple_appcache_system.h View 1 2 3 4 4 chunks +4 lines, -5 lines 0 comments Download
M webkit/tools/test_shell/simple_appcache_system.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +2 lines, -1 line 0 comments Download
M webkit/tools/test_shell/simple_file_writer.h View 1 2 3 4 4 chunks +5 lines, -4 lines 0 comments Download
M webkit/tools/test_shell/simple_socket_stream_bridge.h View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tfarina
Please, take a look.
9 years, 11 months ago (2011-01-04 17:38:53 UTC) #1
willchan no longer on Chromium
LGTM On Tue, Jan 4, 2011 at 9:38 AM, <tfarina@chromium.org> wrote: > Reviewers: willchan, wtc, ...
9 years, 11 months ago (2011-01-04 18:36:26 UTC) #2
wtc
LGTM. http://codereview.chromium.org/6056007/diff/6001/net/url_request/url_request_test_job.cc File net/url_request/url_request_test_job.cc (right): http://codereview.chromium.org/6056007/diff/6001/net/url_request/url_request_test_job.cc#newcode19 net/url_request/url_request_test_job.cc:19: static std::vector< scoped_refptr<URLRequestTestJob> > pending_jobs; Nit: add a ...
9 years, 11 months ago (2011-01-05 00:19:40 UTC) #3
tfarina
Sent to the trybots. http://codereview.chromium.org/6056007/diff/6001/net/url_request/url_request_test_job.cc File net/url_request/url_request_test_job.cc (right): http://codereview.chromium.org/6056007/diff/6001/net/url_request/url_request_test_job.cc#newcode19 net/url_request/url_request_test_job.cc:19: static std::vector< scoped_refptr<URLRequestTestJob> > pending_jobs; ...
9 years, 11 months ago (2011-01-05 01:09:59 UTC) #4
wtc
Patch Set 4 LGTM.
9 years, 11 months ago (2011-01-05 01:47:50 UTC) #5
tfarina
On 2011/01/05 01:47:50, wtc wrote: > Patch Set 4 LGTM. Please, take a look at ...
9 years, 11 months ago (2011-01-05 01:53:51 UTC) #6
wtc
9 years, 11 months ago (2011-01-05 02:07:33 UTC) #7
Patch Set 5 LGTM.

Powered by Google App Engine
This is Rietveld 408576698