Issue 6056006: Fix Windows compilation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6056006: Fix Windows compilation (Closed)

Created:
9 years, 11 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
piscisaureus, Rico

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix Windows compilation Use strncpy_s instaad of strncpy to avoid warning. Committed: http://code.google.com/p/v8/source/detail?r=6151

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/platform-win32.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

piscisaureus

9 years, 11 months ago (2011-01-17 20:04:55 UTC) #3

Does this actually work on msvc?
On mingw it certainly doesn't because strncpy_s takes 4 arguments, not 3.
I think it should be strncpy_s(name_, sizeof(name_), name, strlen(name))

Expand Messages | Collapse Messages