Fix inlining of instanceof stub for ARM (r6093).

Fix inlining of instanceof stub for ARM (r6093).

Committed: http://code.google.com/p/v8/source/detail?r=6117

[Vyacheslav Egorov (Chromium), 2010-12-23 15:49:09]

LGTM

http://codereview.chromium.org/6055006/diff/1/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):

http://codereview.chromium.org/6055006/diff/1/src/arm/code-stubs-arm.cc#newco...
src/arm/code-stubs-arm.cc:2897: // object in r0 (or at sp+1*ptrsz) and function
in
ptrsz => kPointerSize ?

http://codereview.chromium.org/6055006/diff/1/src/arm/code-stubs-arm.cc#newco...
src/arm/code-stubs-arm.cc:2925: __ LoadRoot(object,
Heap::kInstanceofCacheAnswerRootIndex);
r0 instead of object to reduce confusion

http://codereview.chromium.org/6055006/diff/1/src/arm/code-stubs-arm.cc#newco...
src/arm/code-stubs-arm.cc:2991: __ push(r0);
__ Push(r0, r1);

?

http://codereview.chromium.org/6055006/diff/1/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):

http://codereview.chromium.org/6055006/diff/1/src/arm/lithium-codegen-arm.cc#...
src/arm/lithium-codegen-arm.cc:1340: ASSERT(ToRegister(instr->left()).is(r0)); 
// object is in r0
// Object is in r0.

something like that

http://codereview.chromium.org/6055006/diff/1/src/arm/lithium-codegen-arm.cc#...
src/arm/lithium-codegen-arm.cc:1341: ASSERT(ToRegister(instr->right()).is(r1)); 
// function is in r1
ditto

[Karl Klose, 2010-12-23 16:15:46]

http://codereview.chromium.org/6055006/diff/1/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):

http://codereview.chromium.org/6055006/diff/1/src/arm/code-stubs-arm.cc#newco...
src/arm/code-stubs-arm.cc:2897: // object in r0 (or at sp+1*ptrsz) and function
in
On 2010/12/23 15:49:09, Vyacheslav Egorov wrote:
> ptrsz => kPointerSize ?
> 

Done.

http://codereview.chromium.org/6055006/diff/1/src/arm/code-stubs-arm.cc#newco...
src/arm/code-stubs-arm.cc:2925: __ LoadRoot(object,
Heap::kInstanceofCacheAnswerRootIndex);
On 2010/12/23 15:49:09, Vyacheslav Egorov wrote:
> r0 instead of object to reduce confusion

Done.

http://codereview.chromium.org/6055006/diff/1/src/arm/code-stubs-arm.cc#newco...
src/arm/code-stubs-arm.cc:2991: __ push(r0);
On 2010/12/23 15:49:09, Vyacheslav Egorov wrote:
> __ Push(r0, r1);
> 
> ?

Done.

http://codereview.chromium.org/6055006/diff/1/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):

http://codereview.chromium.org/6055006/diff/1/src/arm/lithium-codegen-arm.cc#...
src/arm/lithium-codegen-arm.cc:1340: ASSERT(ToRegister(instr->left()).is(r0)); 
// object is in r0
On 2010/12/23 15:49:09, Vyacheslav Egorov wrote:
> // Object is in r0.
> 
> something like that

Done.

http://codereview.chromium.org/6055006/diff/1/src/arm/lithium-codegen-arm.cc#...
src/arm/lithium-codegen-arm.cc:1341: ASSERT(ToRegister(instr->right()).is(r1)); 
// function is in r1
On 2010/12/23 15:49:09, Vyacheslav Egorov wrote:
> ditto

Done.