Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 6055004: Fix bug 10466: parallel_emerge use flag calculation favors local binhost. (Closed)

Created:
10 years ago by davidjames
Modified:
9 years, 4 months ago
Reviewers:
Nick Sanders
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Fix bug 10466: parallel_emerge use flag calculation favors local binhost. When we merge a package, we need to keep track of the use flags associated with the package, so that we don't merge a package with the wrong use flags. In some cases, there might be two copies of the same binary package: One local copy, and one remote copy. Our current logic for grabbing the use flags favors the local copy. But Portage itself favors the remote copy. To reconcile this difference, we just reuse the logic from Portage here. BUG=chromium-os:10466 TEST= 1. Run build_packages with a correct binhost 2. Switch to a binhost with different use flags for some of the packages, but the same version number and package name. 3. Run EXTRA_BOARD_FLAGS=--emptytree build_packages 4. Run build_image Also test #3 with --oldchromebinary. Change-Id: I9b917d8b8d902e0581d5a5d23ad20940930b114a Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=999e09f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -25 lines) Patch
M parallel_emerge View 1 chunk +7 lines, -25 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
davidjames
10 years ago (2010-12-20 17:11:37 UTC) #1
davidjames
Some explanation of the bug this is fixing: emerge has a bug in its API. ...
10 years ago (2010-12-22 16:15:56 UTC) #2
Nick Sanders
9 years, 11 months ago (2011-01-04 23:12:13 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698