Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2546)

Unified Diff: chrome/browser/renderer_host/safe_browsing_resource_handler.cc

Issue 6055002: Create a message filter for message port messages. This allows a nice cleanu... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/safe_browsing_resource_handler.cc
===================================================================
--- chrome/browser/renderer_host/safe_browsing_resource_handler.cc (revision 69724)
+++ chrome/browser/renderer_host/safe_browsing_resource_handler.cc (working copy)
@@ -6,10 +6,8 @@
#include "base/logging.h"
#include "chrome/browser/renderer_host/global_request_id.h"
-#include "chrome/browser/renderer_host/render_message_filter.h"
#include "chrome/browser/renderer_host/resource_dispatcher_host.h"
#include "chrome/browser/renderer_host/resource_message_filter.h"
-#include "chrome/common/notification_service.h"
#include "chrome/common/resource_response.h"
#include "net/base/net_errors.h"
#include "net/base/io_buffer.h"
@@ -38,8 +36,6 @@
safe_browsing_(safe_browsing),
rdh_(resource_dispatcher_host),
resource_type_(resource_type) {
- registrar_.Add(this, NotificationType::RESOURCE_MESSAGE_FILTER_SHUTDOWN,
- NotificationService::AllSources());
}
SafeBrowsingResourceHandler::~SafeBrowsingResourceHandler() {
@@ -204,15 +200,6 @@
Release(); // Balances the AddRef() in StartDisplayingBlockingPage().
}
-void SafeBrowsingResourceHandler::Observe(NotificationType type,
- const NotificationSource& source,
- const NotificationDetails& details) {
- if (Source<ResourceMessageFilter>(source).ptr()->child_id() ==
- render_process_host_id_) {
- Shutdown();
- }
-}
-
void SafeBrowsingResourceHandler::Shutdown() {
if (state_ == STATE_CHECKING_URL) {
timer_.Stop();

Powered by Google App Engine
This is Rietveld 408576698