Create a message filter for message port messages. This allows a nice cleanu...

chrome/browser/renderer_host/safe_browsing_resource_handler.h

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_RENDERER_HOST_SAFE_BROWSING_RESOURCE_HANDLER_H_
 #define CHROME_BROWSER_RENDERER_HOST_SAFE_BROWSING_RESOURCE_HANDLER_H_
 #pragma once
 
 #include <string>
 
 #include "base/ref_counted.h"
 #include "base/time.h"
 #include "base/timer.h"
 #include "chrome/browser/renderer_host/resource_handler.h"
 #include "chrome/browser/safe_browsing/safe_browsing_service.h"
-#include "chrome/common/notification_observer.h"
-#include "chrome/common/notification_registrar.h"
 
 class ResourceDispatcherHost;
 
 // SafeBrowsingResourceHandler checks that URLs are "safe" before navigating
 // to them. To be considered "safe", a URL must not appear in the
 // malware/phishing blacklists (see SafeBrowsingService for details).
 //
 // This check is done before requesting the original URL, and additionally
 // before following any subsequent redirect.
 //
 // In the common case, the check completes synchronously (no match in the bloom
 // filter), so the request's flow is un-interrupted.
 //
 // However if the URL fails this quick check, it has the possibility of being
 // on the blacklist. Now the request is suspended (prevented from starting),
 // and a more expensive safe browsing check is begun (fetches the full hashes).
 //
 // Note that the safe browsing check takes at most kCheckUrlTimeoutMs
 // milliseconds. If it takes longer than this, then the system defaults to
 // treating the URL as safe.
 //
 // Once the safe browsing check has completed, if the URL was decided to be
 // dangerous, a warning page is thrown up and the request remains suspended.
 // If on the other hand the URL was decided to be safe, the request is
 // resumed.
 class SafeBrowsingResourceHandler : public ResourceHandler,
-                                    public SafeBrowsingService::Client,
-                                    public NotificationObserver {
+                                    public SafeBrowsingService::Client {
  public:
   SafeBrowsingResourceHandler(ResourceHandler* handler,
                               int render_process_host_id,
                               int render_view_id,
                               ResourceType::Type resource_type,
                               SafeBrowsingService* safe_browsing,
                               ResourceDispatcherHost* resource_dispatcher_host);
 
   // ResourceHandler implementation:
   virtual bool OnUploadProgress(int request_id, uint64 position, uint64 size);
@@ skipping 11 matching lines @@
 
   // SafeBrowsingService::Client implementation, called on the IO thread once
   // the URL has been classified.
   virtual void OnBrowseUrlCheckResult(
       const GURL& url, SafeBrowsingService::UrlCheckResult result);
 
   // SafeBrowsingService::Client implementation, called on the IO thread when
   // the user has decided to proceed with the current request, or go back.
   virtual void OnBlockingPageComplete(bool proceed);
 
-  // NotificationObserver interface.
-  virtual void Observe(NotificationType type,
-                       const NotificationSource& source,
-                       const NotificationDetails& details);
-
  private:
   // Describes what phase of the check a handler is in.
   enum State {
     STATE_NONE,
     STATE_CHECKING_URL,
     STATE_DISPLAYING_BLOCKING_PAGE,
   };
 
   // Describes what stage of the request got paused by the check.
   enum DeferState {
@@ skipping 46 matching lines @@
 
   // Timer to abort the safe browsing check if it takes too long.
   base::OneShotTimer<SafeBrowsingResourceHandler> timer_;
 
   // Details on the deferred request (either a start or redirect). It is only
   // valid to access these members when defer_state_ != DEFERRED_NONE.
   GURL deferred_url_;
   int deferred_request_id_;
   scoped_refptr<ResourceResponse> deferred_redirect_response_;
 
-  NotificationRegistrar registrar_;
   scoped_refptr<ResourceHandler> next_handler_;
   int render_process_host_id_;
   int render_view_id_;
   scoped_refptr<SafeBrowsingService> safe_browsing_;
   ResourceDispatcherHost* rdh_;
   ResourceType::Type resource_type_;
 
   DISALLOW_COPY_AND_ASSIGN(SafeBrowsingResourceHandler);
 };
 
 
 #endif  // CHROME_BROWSER_RENDERER_HOST_SAFE_BROWSING_RESOURCE_HANDLER_H_