Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4983)

Unified Diff: chrome/browser/ui/browser.cc

Issue 6053012: This adds a "killed tab" page and pages reload when killed on ChromeOS (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Pre-review tweaks Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index bed9899b6c1de53de5a6a2e32898c40a4ca35f35..33b396ef375aaf15c1a3479aafac9a64b564fc7d 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -2626,6 +2626,17 @@ void Browser::TabSelectedAt(TabContentsWrapper* old_contents,
bool user_gesture) {
DCHECK(old_contents != new_contents);
+#if defined(OS_CHROMEOS)
brettw 2011/01/12 07:22:58 This kind of thing in browser.cc gives Ben hives a
Ben Goodger (Google) 2011/01/12 15:34:11 There are a couple of approaches here I can think
+ // On ChromeOS, we want to automatically reload tabs that are killed
+ // when the user selects them.
+ if (user_gesture &&
+ new_contents->tab_contents()->crashed_status() ==
+ base::TERMINATION_STATUS_PROCESS_WAS_KILLED) {
+ Reload(CURRENT_TAB);
+ return;
+ }
+#endif
+
// If we have any update pending, do it now.
if (!chrome_updater_factory_.empty() && old_contents)
ProcessPendingUIUpdates();

Powered by Google App Engine
This is Rietveld 408576698