This adds a "killed tab" page and pages reload when killed on ChromeOS

This adds a "killed tab" page to be displayed in the case where a tab is killed instead of crashing.

It also adds "about:kill" to simulate kills.

On ChromeOS killed tabs will be reloaded as soon as the user clicks on them unless they are the only tab, or the currently focused tab is killed.

BUG=http://crosbug.com/10043, http://crosbug.com/10711
TEST=Built linux and ChromeOS Chrome and killed a tab, and then did about:crash and made sure that the "Aw, Snap!" page was displayed. Did about:kill and made sure kill page was displayed.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71360

[Greg Spencer (Chromium), 2011-01-10 22:20:04]

Brett, please let me know if you don't have time for this review.  I picked you
because you reviewed the plumbing changes for this feature.  This is the UI side
that uses that plumbing.

[brettw, 2011-01-12 00:42:26]

Looking now.

[brettw, 2011-01-12 07:22:58]

Aside from hoping we can find a better solution for the ifdef, this looks pretty
straightforward.

http://codereview.chromium.org/6053012/diff/13001/chrome/browser/ui/browser.cc
File chrome/browser/ui/browser.cc (right):

http://codereview.chromium.org/6053012/diff/13001/chrome/browser/ui/browser.c...
chrome/browser/ui/browser.cc:2629: #if defined(OS_CHROMEOS)
This kind of thing in browser.cc gives Ben hives and makes me sad too. Can you
think of a way to avoid putting this in a global platform-independent file? We
can check with Ben tomorrow to see if he has a preferred way to do this.

http://codereview.chromium.org/6053012/diff/13001/chrome/browser/ui/views/tab...
File chrome/browser/ui/views/tab_contents/tab_contents_view_views.cc (right):

http://codereview.chromium.org/6053012/diff/13001/chrome/browser/ui/views/tab...
chrome/browser/ui/views/tab_contents/tab_contents_view_views.cc:141:
SadTabView::KILLED : SadTabView::CRASHED));
I'd probably indent this 2 more spaces.

[Ben Goodger (Google), 2011-01-12 15:34:11]

http://codereview.chromium.org/6053012/diff/13001/chrome/browser/ui/browser.cc
File chrome/browser/ui/browser.cc (right):

http://codereview.chromium.org/6053012/diff/13001/chrome/browser/ui/browser.c...
chrome/browser/ui/browser.cc:2629: #if defined(OS_CHROMEOS)
There are a couple of approaches here I can think of.

One would be if it seems like this feature may make it into non-ChromeOS Chrome
at some point, it should be behind a flag then that ChromeOS can default-on.
Then the code can just live here. It is possible that with future tabstrip
designs where we accumulate an infinite number of tabs that we will want this
behavior everywhere.

Alternatively ChromeOS could define its own TabStripModelObserver. This is more
applicable if there are or will be other ChromeOS ifdefs in the
TabStripModelObserver implementation.

[Ben Goodger (Google), 2011-01-12 18:12:11]

On Wed, Jan 12, 2011 at 10:09 AM, Greg Spencer <gspencer@chromium.org>wrote:

> Well, this is hardly the first ifdef in that file (there are 18 other
> chromeos-specific ifdefs there),
>

I am writing a Q1 OKR for the ChromeOS and Chrome FE teams to identify these
and remove all that we can. The growing impact of our various supported
platforms on cross platform code by way of ifdefs is undesirable and must be
stopped.

-Ben

[Greg Spencer, 2011-01-12 18:16:48]

On Wed, Jan 12, 2011 at 10:12 AM, Ben Goodger (Google) <ben@chromium.org>wrote:

> On Wed, Jan 12, 2011 at 10:09 AM, Greg Spencer <gspencer@chromium.org>wrote:
>
>> Well, this is hardly the first ifdef in that file (there are 18 other
>> chromeos-specific ifdefs there),
>>
>
> I am writing a Q1 OKR for the ChromeOS and Chrome FE teams to identify
> these and remove all that we can. The growing impact of our various
> supported platforms on cross platform code by way of ifdefs is undesirable
> and must be stopped.
>

Sounds like a good idea.  I agree that this will all start to get out of
hand quickly.

-Greg.

[Greg Spencer (Chromium), 2011-01-12 18:18:39]

On Wed, Jan 12, 2011 at 7:34 AM, <ben@chromium.org> wrote:
>
>
> http://codereview.chromium.org/6053012/diff/13001/chrome/browser/ui/browser.cc
> File chrome/browser/ui/browser.cc (right):
>
>
>
http://codereview.chromium.org/6053012/diff/13001/chrome/browser/ui/browser.c...
> chrome/browser/ui/browser.cc:2629: #if defined(OS_CHROMEOS)
> There are a couple of approaches here I can think of.
>
> One would be if it seems like this feature may make it into non-ChromeOS
> Chrome at some point, it should be behind a flag then that ChromeOS can
> default-on. Then the code can just live here. It is possible that with
> future tabstrip designs where we accumulate an infinite number of tabs
> that we will want this behavior everywhere.
>

Well, this is hardly the first ifdef in that file (there are 18 other
chromeos-specific ifdefs there), but I'm happy to convert this into a flag.
I have a strong feeling that this behavior will be desired on other
platforms eventually (it's why I worked to make sure that we could detect
killed tabs on other platforms).
I'll update the CL when I'm no longer getting 500s from the code review
server. :-P

-Greg.

[Greg Spencer (Chromium), 2011-01-13 00:23:15]

On 2011/01/12 18:18:39, Greg Spencer (Chromium) wrote:
> I'll update the CL when I'm no longer getting 500s from the code review
> server. :-P

OK, please take another look.  I added the flag "--reload-killed-tabs"

-Greg.

[brettw, 2011-01-13 04:43:22]

LGTM