Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6052008: harfbuzz: check in harfbuzz-ng, add gyp define to use it (Closed)

Created:
9 years, 11 months ago by Evan Martin
Modified:
9 years, 7 months ago
Reviewers:
tony, agl
CC:
chromium-reviews, jshin+watch_chromium.org
Visibility:
Public.

Description

harfbuzz: check in harfbuzz-ng, add gyp define to use it This checks in harbuzz-ng b0d396aa88b3cdf8cea896bfeeba197656e1cdb1. Setting use_harfbuzz_ng to 1 in gyp will cause us to build harfbuzz-ng in place of harfbuzz. So far this currently fails to compile due to all our other code relying on the old API. BUG=68551 TEST=./build/gyp_chromium -Duse_harfbuzz_ng=1, verify build breaks Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70539

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14954 lines, -39 lines) Patch
M build/common.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/AUTHORS View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/harfbuzz-ng/COPYING View 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/README View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/README.chromium View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/harfbuzz.gyp View 1 chunk +73 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/Makefile.am View 1 chunk +147 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/check-c-linkage-decls.sh View 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/check-header-guards.sh View 1 chunk +20 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/check-internal-symbols.sh View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/check-libstdc++.sh View 1 chunk +27 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/gen-arabic-joining-table.py View 1 chunk +83 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb.h View 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-blob.h View 1 chunk +89 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-blob.c View 1 chunk +362 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-blob-private.h View 1 chunk +59 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-buffer.h View 1 chunk +163 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-buffer.cc View 1 chunk +630 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-buffer-private.hh View 1 chunk +146 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-common.h View 1 chunk +106 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-common.c View 1 chunk +47 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-font.h View 1 chunk +270 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-font.cc View 1 chunk +583 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-font-private.h View 1 chunk +97 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-ft.h View 1 chunk +58 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-ft.c View 1 chunk +262 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-glib.h View 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-glib.c View 1 chunk +64 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-graphite.h View 1 chunk +47 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-graphite.cc View 1 chunk +310 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-icu.h View 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-icu.c View 1 chunk +260 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-language.h View 1 chunk +46 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-language.c View 1 chunk +120 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-object-private.h View 1 chunk +141 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-open-file-private.hh View 1 chunk +258 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-open-type-private.hh View 1 chunk +727 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-ot.h View 1 chunk +39 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-ot-head-private.hh View 1 chunk +146 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-ot-layout.h View 1 chunk +196 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-ot-layout.cc View 1 chunk +485 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-ot-layout-common-private.hh View 1 chunk +604 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-ot-layout-gdef-private.hh View 1 chunk +429 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-ot-layout-gpos-private.hh View 1 chunk +1588 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-ot-layout-gsub-private.hh View 1 chunk +931 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-ot-layout-gsubgpos-private.hh View 1 chunk +981 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-ot-layout-private.hh View 1 chunk +114 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-ot-map.cc View 1 chunk +194 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-ot-map-private.hh View 1 chunk +143 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-ot-shape.h View 1 chunk +46 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-ot-shape.cc View 1 chunk +382 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-ot-shape-complex-arabic.cc View 1 chunk +198 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-ot-shape-complex-arabic-table.h View 1 chunk +674 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-ot-shape-complex-private.hh View 1 chunk +97 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-ot-shape-private.hh View 1 chunk +76 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-ot-tag.h View 1 chunk +54 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-ot-tag.c View 1 chunk +703 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-private.h View 1 chunk +270 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-shape.h View 1 chunk +54 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-shape.cc View 1 chunk +65 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-unicode.h View 1 chunk +294 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-unicode.c View 1 chunk +364 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-unicode-private.h View 1 chunk +64 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/main.cc View 1 chunk +196 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/test.c View 1 chunk +94 lines, -0 lines 0 comments Download
M third_party/harfbuzz/harfbuzz.gyp View 1 1 chunk +59 lines, -40 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Evan Martin
(this is blocked on the webkit roll once https://bugs.webkit.org/show_bug.cgi?id=51895 lands...) Files to review: common.gypi, README.chromium, ...
9 years, 11 months ago (2011-01-04 23:11:21 UTC) #1
tony
9 years, 11 months ago (2011-01-05 00:52:35 UTC) #2 
Rubber stamp, LGTM (I looked at README.chromium and the gyp changes).

Powered by Google App Engine
This is Rietveld 408576698