Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3361)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/process_info_snapshot_mac_unittest.cc

Issue 6052005: Proposal: Use /usr/bin/top in about:memory... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/process_info_snapshot_mac.cc ('K') | « chrome/browser/process_info_snapshot_mac.cc ('k') | chrome/browser/resources/about_memory_mac.html » ('j') | chrome/browser/resources/about_memory_mac.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/process_info_snapshot_mac_unittest.cc
===================================================================
--- chrome/browser/process_info_snapshot_mac_unittest.cc (revision 70404)
+++ chrome/browser/process_info_snapshot_mac_unittest.cc (working copy)
@@ -77,6 +77,8 @@
// should occupy at least 100 kilobytes.
EXPECT_GE(proc_info.vsize, 1024u); // Sanity check: our |vsize| is presumably
// at least a megabyte.
+ EXPECT_GE(proc_info.rshrd, 1024u); // Shared memory should also > 1 MB.
+ EXPECT_GE(proc_info.rprvt, 1024u); // Same with private memory.
// Find our parent.
ASSERT_TRUE(snapshot.GetProcInfo(ppid, &proc_info));
« chrome/browser/process_info_snapshot_mac.cc ('K') | « chrome/browser/process_info_snapshot_mac.cc ('k') | chrome/browser/resources/about_memory_mac.html » ('j') | chrome/browser/resources/about_memory_mac.html » ('J')

Powered by Google App Engine
This is Rietveld 408576698