Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 6050004: Create package keywords directory if it doesn't exist. (Closed)

Created:
10 years ago by sosa
Modified:
9 years, 6 months ago
Reviewers:
anush
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Create package keywords directory if it doesn't exist. Clobbering the builder uncovered a bug that was lurking. Change-Id: Ieb487d2112a7048438943aa96fba23e9c8412a13 BUG=chromium-os:8693 TEST=Running now Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=f58bc38

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M bin/cbuildbot.py View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sosa
10 years ago (2010-12-20 22:19:27 UTC) #1
anush
10 years ago (2010-12-21 01:41:23 UTC) #2
LGTM

On Mon, Dec 20, 2010 at 2:19 PM, <sosa@chromium.org> wrote:

> Reviewers: anush,
>
> Description:
> Create package keywords directory if it doesn't exist.
>
> Clobbering the builder uncovered a bug that was lurking.
>
> Change-Id: Ieb487d2112a7048438943aa96fba23e9c8412a13
>
> BUG=chromium-os:8693
> TEST=Running now
>
> Please review this at http://codereview.chromium.org/6050004/
>
> SVN Base: http://git.chromium.org/git/crosutils.git@master
>
> Affected files:
>  M bin/cbuildbot.py
>
>
> Index: bin/cbuildbot.py
> diff --git a/bin/cbuildbot.py b/bin/cbuildbot.py
> index
>
90e965bb4f496c18aa4dd3f1d3cddec851bfe62a..08a0dcf065353f8ed835a3f085b7cddd187e0e8b
> 100755
> --- a/bin/cbuildbot.py
> +++ b/bin/cbuildbot.py
> @@ -232,10 +232,12 @@ def _MarkChromeAsStable(buildroot, tracking_branch,
> chrome_rev, board):
>     return None
>   else:
>     chrome_atom = portage_atom_string.split('=')[1]
> +    keywords_file = CHROME_KEYWORDS_FILE % {'board': board}
>     # TODO(sosa): Workaround to build unstable chrome ebuild we uprevved.
> -    RunCommand(['sudo', 'tee', CHROME_KEYWORDS_FILE % {'board': board}],
> -               input='=%s\n' % chrome_atom, enter_chroot=True,
> -               cwd=cwd)
> +    RunCommand(['sudo', 'mkdir', '-p', os.path.dirname(keywords_file)],
> +               enter_chroot=True, cwd=cwd)
> +    RunCommand(['sudo', 'tee', keywords_file], input='=%s\n' %
> chrome_atom,
> +               enter_chroot=True, cwd=cwd)
>     return chrome_atom
>
>
>
>
>

Powered by Google App Engine
This is Rietveld 408576698