Issue 6049008: SSE2 truncating double-to-i.

Issue 6049008: SSE2 truncating double-to-i. (Closed)

Created:
9 years, 11 months ago by Vitaly Repeshko

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Visibility:
Public.

Description

SSE2 truncating double-to-i. Committed: http://code.google.com/p/v8/source/detail?r=6269

Patch Set 4 : Update exponent limit description #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+173 lines, -11 lines)			Patch
M	src/assembler.h	View	1 2	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/assembler.cc	View	1 2	2 chunks	+7 lines, -0 lines	0 comments	Download
M	src/ia32/assembler-ia32.h	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/ia32/assembler-ia32.cc	View	1 2	2 chunks	+45 lines, -0 lines	0 comments	Download
M	src/ia32/disasm-ia32.cc	View	1 2	2 chunks	+27 lines, -1 line	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1 2 3	1 chunk	+56 lines, -3 lines	0 comments	Download
M	src/ia32/lithium-ia32.h	View		1 chunk	+6 lines, -1 line	0 comments	Download
M	src/ia32/lithium-ia32.cc	View		1 chunk	+6 lines, -2 lines	0 comments	Download
M	src/serialize.cc	View	1 2	1 chunk	+7 lines, -3 lines	0 comments	Download
M	test/cctest/test-disasm-ia32.cc	View	1 2	2 chunks	+13 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

LGTM, if the disassembly is tested in the relevant cctest. http://codereview.chromium.org/6049008/diff/3001/src/ia32/assembler-ia32.h File src/ia32/assembler-ia32.h (right): http://codereview.chromium.org/6049008/diff/3001/src/ia32/assembler-ia32.h#newcode929 ...

9 years, 11 months ago (2011-01-04 22:32:59 UTC) #2

Vitaly Repeshko

All issues addressed. Loading the constant did turn out to be a bit faster than ...

9 years, 11 months ago (2011-01-07 17:19:44 UTC) #3

lgtm

Expand Messages | Collapse Messages