Create IVerifierStatus and add IVerifierStatus.ignored().

verification/base.py

 # coding=utf8
 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 """Defines base classes for pending change verification classes."""
 
 import model
 
 
 class DiscardPending(Exception):
@@ skipping 26 matching lines @@
     if not self.verifications:
       return False
     return all(v.succeeded() for v in self.verifications.itervalues())
 
   def failed(self):
     """At least one verification failed."""
     if not self.verifications:
       return False
     return any(v.failed() for v in self.verifications.itervalues())
 
+  def ignored(self):
+    """This item shouldn't be processed any further.
 
-class SimpleStatus(model.PersistentMixIn):
+    At least one verification step marked it as ignored.
+    """
+    if not self.verifications:
+      return False
+    return any(v.ignored() for v in self.verifications.itervalues())
+
+  def done(self):
+    """Processing on this item is done."""
+    return self.ignored() or self.succeeded() or self.failed()
+
+
+class IVerifierStatus(model.PersistentMixIn):
+  """Interface for objects in Verified.verifications dictionary."""
+  def succeeded(self):
+    raise NotImplementedError()
+
+  def failed(self):
+    raise NotImplementedError()
+
+  def ignored(self):
+    raise NotImplementedError()
+
+  def done(self):
+    return self.ignored() or self.succeeded() or self.failed()
+
+
+class SimpleStatus(IVerifierStatus):
   """Base class to be used for simple true/false verifiers."""
   def __init__(self, state=None):
     super(SimpleStatus, self).__init__()
     self.state = state
 
   def succeeded(self):
     return self.state is True
 
   def failed(self):
     return self.state is False
 
+  def ignored(self):
+    return False
+
 
 class Verifier(object):
   name = None
 
   def verify(self, pending, revision):
     raise NotImplementedError()
 
   def update_status(self, queue):
     raise NotImplementedError()
 
   def loop(self, queue, gen_obj):
     """Loops in a pending queue and returns the verified item corresponding to
     the Verifier.
     """
     for pending in queue:
       if not pending.verifications.get(self.name, None):
         pending.verifications[self.name] = gen_obj()
       yield pending, pending.verifications[self.name]