Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 6047005: chromeos: Notify window manager about signout. (Closed)

Created:
10 years ago by Daniel Erat
Modified:
9 years, 7 months ago
Reviewers:
Chris Masone
CC:
chromium-reviews, pam+watch_chromium.org, nkostylev+cc_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

chromeos: Notify window manager about signout. This makes us send a message to the window manager when the user is logging out so the window manager can display a more graceful transition (currently, you can sometimes see the browser windows getting closed one by one). The power manager already sends a similar message to the window manager when we're shutting down. BUG=chromium-os:9915 TEST=built and tried it with an updated window manager. try bots pass too Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70270

Patch Set 1 #

Patch Set 2 : DEPS already updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M chrome/browser/browser_shutdown.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/screen_locker.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/wm_ipc.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/wm_ipc.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_list.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Daniel Erat
10 years ago (2010-12-22 23:03:59 UTC) #1
Daniel Erat
My buildbot run failed. Do cros_deps updates need to be checked in in a separate ...
10 years ago (2010-12-22 23:43:12 UTC) #2
Chris Masone
On 2010/12/22 23:43:12, Daniel Erat wrote: > My buildbot run failed. Do cros_deps updates need ...
10 years ago (2010-12-23 00:26:58 UTC) #3
Daniel Erat
Another look?
9 years, 11 months ago (2010-12-29 16:26:18 UTC) #4
Chris Masone
9 years, 11 months ago (2010-12-29 18:20:48 UTC) #5
On 2010/12/29 16:26:18, Daniel Erat wrote:
> Another look?

LGTM

Powered by Google App Engine
This is Rietveld 408576698