Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1001)

Issue 6046009: Move base/mac_util.h to base/mac and use the base::mac namespace.... (Closed)

Created:
9 years, 11 months ago by brettw
Modified:
9 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, cbentzel+watch_chromium.org, Ilya Sherman, Erik does not do reviews, Paweł Hajdan Jr., jam, Aaron Boodman, darin-cc_chromium.org, brettw-cc_chromium.org, pam+watch_chromium.org, James Hawkins, stuartmorgan+watch_chromium.org, dhollowa
Visibility:
Public.

Description

Move base/mac_util.h to base/mac and use the base::mac namespace. Fix up callers to use the new location & namespace. Remove includes from  files where it wasn't necessary. TEST=it compiles BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70359

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+349 lines, -1516 lines) Patch
M app/clipboard/clipboard_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M app/mac/nsimage_cache.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M app/resource_bundle_mac.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M app/test_suite.h View 3 chunks +7 lines, -5 lines 0 comments Download
M base/base.gyp View 1 chunk +1 line, -1 line 0 comments Download
M base/base.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M base/base_paths_mac.mm View 2 chunks +4 lines, -4 lines 0 comments Download
M base/file_version_info_mac.mm View 2 chunks +3 lines, -3 lines 0 comments Download
A + base/mac/mac_util.h View 3 chunks +7 lines, -5 lines 0 comments Download
A + base/mac/mac_util.mm View 1 7 chunks +15 lines, -15 lines 0 comments Download
A + base/mac/mac_util_unittest.mm View 5 chunks +9 lines, -8 lines 0 comments Download
D base/mac_util.h View 1 chunk +0 lines, -247 lines 0 comments Download
D base/mac_util.mm View 1 chunk +0 lines, -716 lines 0 comments Download
D base/mac_util_unittest.mm View 1 chunk +0 lines, -196 lines 0 comments Download
M chrome/app/breakpad_mac.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/app/chrome_main.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/app_controller_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_popup_view_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/history_url_provider_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
MM chrome/browser/autofill/autofill_address_sheet_controller_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
MM chrome/browser/autofill/autofill_credit_card_sheet_controller_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/autofill/autofill_dialog_controller_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/background_mode_manager_mac.mm View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/browser_main_mac.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/bug_report_util.h View 1 chunk +5 lines, -7 lines 0 comments Download
M chrome/browser/dom_ui/bug_report_ui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/history/history_database.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/history/thumbnail_database.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/importer/importer_list.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/memory_details_mac.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/page_info_model.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/password_manager/password_store_mac.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/platform_util_mac.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/plugin_process_host.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/plugin_process_host_mac.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/renderer_host/backing_store_mac.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/shell_integration_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/about_ipc_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/about_window_controller.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/animatable_image.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/authorization_util.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/base_bubble_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bug_report_window_controller.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/chrome_event_processing_window_unittest.mm View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/clear_browsing_data_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/cocoa_test_helper.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/cocoa_test_helper.mm View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/collected_cookies_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
MM chrome/browser/ui/cocoa/confirm_quit_panel_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/content_exceptions_window_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/content_settings_dialog_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/cookie_details_view_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/cookies_window_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/download/download_item_cell.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/download/download_item_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/download/download_shelf_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/edit_search_engine_cocoa_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/extension_installed_bubble_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_install_prompt_controller.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/file_metadata.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/find_bar_cocoa_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/first_run_dialog.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/floating_bar_backing_view.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/font_language_settings_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/fullscreen_controller.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/fullscreen_controller.mm View 7 chunks +17 lines, -16 lines 0 comments Download
M chrome/browser/ui/cocoa/fullscreen_window.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/hung_renderer_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/import_progress_dialog.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/import_settings_dialog.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/importer_lock_dialog.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/infobar_container_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/infobar_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/install_from_dmg.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/instant_confirm_window_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/keystone_glue.mm View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/keyword_editor_cocoa_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/instant_opt_in_controller.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/notifications/balloon_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/nsimage_cache_unittest.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/preferences_window_controller.mm View 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/previewable_contents_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/sad_tab_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/search_engine_dialog_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/shell_dialogs_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/simple_content_exceptions_window_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
MM chrome/browser/ui/cocoa/speech_input_window_controller.mm View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_contents_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tab_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_strip_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tab_strip_view.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_view.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/tabpose_window.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/task_manager_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/translate/translate_infobar_base.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/login/login_prompt_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/chrome_paths.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/common/chrome_paths_mac.mm View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/common/font_loader_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/sandbox_mac.mm View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/plugin/plugin_thread.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/plugin/webplugin_proxy.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/render_process_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/webplugin_delegate_pepper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/in_process_browser_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/unit/chrome_test_suite.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M gfx/blit.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gfx/scoped_image.h View 2 chunks +2 lines, -2 lines 0 comments Download
M gfx/scoped_image_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M gfx/test_suite.h View 2 chunks +7 lines, -7 lines 0 comments Download
M net/proxy/proxy_config_service_mac.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/proxy/proxy_resolver_mac.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/proxy/proxy_server_mac.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M skia/ext/bitmap_platform_device_mac.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/plugins/npapi/plugin_list_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/ppb_graphics_2d_impl.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M webkit/support/platform_support_mac.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/support/test_webkit_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/run_all_tests.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_shell.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webkit/tools/test_shell/test_shell_mac.mm View 5 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
TBR I had to add an additional include to chrome/browser/ui/cocoa/chrome_event_processing_window_unittest.mm to make it compile since ...
9 years, 11 months ago (2011-01-01 18:19:34 UTC) #1
Avi (use Gerrit)
9 years, 11 months ago (2011-01-01 21:36:06 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698