Issue 6046001: DOMUI: Cleanup options_page.css a bit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6046001: DOMUI: Cleanup options_page.css a bit. (Closed)

Created:
10 years ago by James Hawkins

Modified:
9 years, 7 months ago

Reviewers:
stuartmorgan, arv (Not doing code reviews)

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

DOMUI: Cleanup options_page.css a bit. * Move the 'display: block' property of labels into the checkbox and radio classes. * Remove now-superfluous properties. * Use input[type=checkbox] instead of the checkbox class where possible. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69612

Patch Set 1 #

Total comments: 2

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -21 lines)			Patch
	M	chrome/browser/resources/options/options_page.css	View		2 chunks	+9 lines, -21 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

stuartmorgan

LGTM http://codereview.chromium.org/6046001/diff/1/chrome/browser/resources/options/options_page.css File chrome/browser/resources/options/options_page.css (right): http://codereview.chromium.org/6046001/diff/1/chrome/browser/resources/options/options_page.css#newcode327 chrome/browser/resources/options/options_page.css:327: section > div:only-of-type label { Lets axe the ...

10 years ago (2010-12-18 00:49:37 UTC) #3

James Hawkins

10 years ago (2010-12-18 00:54:40 UTC) #4

http://codereview.chromium.org/6046001/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/options_page.css (right):

http://codereview.chromium.org/6046001/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/options_page.css:327: section >
div:only-of-type label {
On 2010/12/18 00:49:38, stuartmorgan wrote:
> Lets axe the whole 'div:only-of-type' part now too, and remove the comment.

I'm hesitant to remove this right now, because it does affect the layout.  We
need to properly add the 'margin: 5px 0', but I need to think about how we're
going to do spacing correctly for all the places we need it in the page.

Expand Messages | Collapse Messages