Issue 6045005: Add support for reporting crashes in the Chrome installer. This basically inv...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6045005: Add support for reporting crashes in the Chrome installer. This basically inv... (Closed)

Created:
10 years ago by ananta

Modified:
9 years, 6 months ago

Reviewers:
robertshield

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add support for reporting crashes in the Chrome installer. This basically involves connecting to the crash service which would take dumps on request. BUG=61609 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69978

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 4

Patch Set 4 : '' #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+84 lines, -0 lines)			Patch
	M	chrome/chrome_installer.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	chrome/installer/setup/setup_main.cc	View	1 2 3	5 chunks	+83 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

robertshield

LGTM http://codereview.chromium.org/6045005/diff/7001/chrome/installer/setup/setup_main.cc File chrome/installer/setup/setup_main.cc (right): http://codereview.chromium.org/6045005/diff/7001/chrome/installer/setup/setup_main.cc#newcode733 chrome/installer/setup/setup_main.cc:733: product = L"Chrome installer"; microscopic nit: "Chrome Installer" ...

10 years ago (2010-12-22 19:02:00 UTC) #2

ananta

10 years ago (2010-12-22 19:13:01 UTC) #3

http://codereview.chromium.org/6045005/diff/7001/chrome/installer/setup/setup...
File chrome/installer/setup/setup_main.cc (right):

http://codereview.chromium.org/6045005/diff/7001/chrome/installer/setup/setup...
chrome/installer/setup/setup_main.cc:733: product = L"Chrome installer";
On 2010/12/22 19:02:00, robertshield wrote:
> microscopic nit: "Chrome Installer" here and on line 73

Done.

http://codereview.chromium.org/6045005/diff/7001/chrome/installer/setup/setup...
chrome/installer/setup/setup_main.cc:769: user_sid = kSystemPrincipalSid;
On 2010/12/22 19:02:00, robertshield wrote:
> Don't need this line since the user_sid is initialized to the system sid
above.

Done.

Expand Messages | Collapse Messages