image_to_live verifies root_dev changed

image_to_live verifies root_dev changed.

Without this, image_to_live can sometimes think that an update from the same version to same version worked when it failed.

BUG=chromium-os:9002
TEST=By hand (hardware && success only)

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=c6c925d

[sosa, 2010-12-21 03:25:09]

Nits

http://codereview.chromium.org/6045004/diff/1/image_to_live.sh
File image_to_live.sh (right):

http://codereview.chromium.org/6045004/diff/1/image_to_live.sh#newcode364
image_to_live.sh:364: INITIAL_ROOT_DEV=$(find_root_dev)
use a local ... local initial_root_dev=

http://codereview.chromium.org/6045004/diff/1/image_to_live.sh#newcode401
image_to_live.sh:401: if [ ${INITIAL_ROOT_DEV} -eq $(find_root_dev) ]; then
Put this under verify image flag above ... only if verify (which is true by
default) than verify we switched

http://codereview.chromium.org/6045004/diff/1/image_to_live.sh#newcode405
image_to_live.sh:405: warn "The root partition did NOT change. The update
failed."
use die rather than warn + return 1 -> error message looks good!

[dgarrett, 2010-12-21 03:50:41]

http://codereview.chromium.org/6045004/diff/1/image_to_live.sh
File image_to_live.sh (right):

http://codereview.chromium.org/6045004/diff/1/image_to_live.sh#newcode364
image_to_live.sh:364: INITIAL_ROOT_DEV=$(find_root_dev)
On 2010/12/21 03:25:09, sosa wrote:
> use a local ... local initial_root_dev=

Done.

http://codereview.chromium.org/6045004/diff/1/image_to_live.sh#newcode401
image_to_live.sh:401: if [ ${INITIAL_ROOT_DEV} -eq $(find_root_dev) ]; then
On 2010/12/21 03:25:09, sosa wrote:
> Put this under verify image flag above ... only if verify (which is true by
> default) than verify we switched

Done.

http://codereview.chromium.org/6045004/diff/1/image_to_live.sh#newcode405
image_to_live.sh:405: warn "The root partition did NOT change. The update
failed."
On 2010/12/21 03:25:09, sosa wrote:
> use die rather than warn + return 1 -> error message looks good!

I was following the pattern from verify_image, but Done.

[sosa, 2010-12-21 05:10:40]

LGTM!  Thanks for getting this in!