Fix the ChromeFrame BeginningTransaction unit test failures which validate th...

Fix the ChromeFrame BeginningTransaction unit test failures which validate the HttpNegotiate
patch. On IE6/7/8 the chrome frame user agent is added to the ua section in the registry. This
causes the test matcher to fail as the actual UA string contains the string chromeframe followed
by the version of the dll.

Fix is to reduce the scope of the matcher to just look for the string chromeframe.

BUG=none
TEST=Covered by existing chrome frame BeginningTransaction test.
TBR=amit



Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69591

[amit, 2010-12-18 18:52:16]

IMO, in this case it's better to have this test only for IE9.

On Fri, Dec 17, 2010 at 4:10 PM, <ananta@chromium.org> wrote:

> Reviewers: amit,
>
> Description:
> Fix the ChromeFrame BeginningTransaction unit test failures which validate
> the
> HttpNegotiate
> patch. On IE6/7/8 the chrome frame user agent is added to the ua section in
> the
> registry. This
> causes the test matcher to fail as the actual UA string contains the string
> chromeframe followed
> by the version of the dll.
>
> Fix is to reduce the scope of the matcher to just look for the string
> chromeframe.
>
> BUG=none
> TEST=Covered by existing chrome frame BeginningTransaction test.
> TBR=amit
>
>
>
> Please review this at http://codereview.chromium.org/6045001/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome_frame/test/http_negotiate_unittest.cc
>
>
> Index: chrome_frame/test/http_negotiate_unittest.cc
> ===================================================================
> --- chrome_frame/test/http_negotiate_unittest.cc        (revision 69586)
> +++ chrome_frame/test/http_negotiate_unittest.cc        (working copy)
> @@ -70,7 +70,7 @@
>   std::wstring cf_tag(
>       ASCIIToWide(http_utils::GetChromeFrameUserAgent()));
>
> -  EXPECT_NE(std::wstring::npos, cf_ua.find(cf_tag));
> +  EXPECT_NE(std::wstring::npos, cf_ua.find(L"chromeframe/"));
>
>   struct TestCase {
>     const std::wstring original_headers_;
>
>
>