Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(818)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/dom_ui/options/add_startup_page_handler.cc

Issue 6044007: Remove wstring from TableModel.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/custom_home_pages_table_model.h ('K') | « chrome/browser/custom_home_pages_table_model.cc ('k') | chrome/browser/dom_ui/options/browser_options_handler.cc » ('j') | chrome/browser/notifications/notification_exceptions_table_model.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/dom_ui/options/add_startup_page_handler.cc
===================================================================
--- chrome/browser/dom_ui/options/add_startup_page_handler.cc (revision 70272)
+++ chrome/browser/dom_ui/options/add_startup_page_handler.cc (working copy)
@@ -75,10 +75,9 @@
ListValue pages;
for (int i = 0; i < url_table_model_->RowCount(); ++i) {
DictionaryValue* dict = new DictionaryValue();
- dict->SetString("title", WideToUTF16Hack(url_table_model_->GetText(
- i, IDS_ASI_PAGE_COLUMN)));
- dict->SetString("displayURL", WideToUTF16Hack(url_table_model_->GetText(
- i, IDS_ASI_URL_COLUMN)));
+ dict->SetString("title", url_table_model_->GetText(i, IDS_ASI_PAGE_COLUMN));
+ dict->SetString("displayURL", url_table_model_->GetText(
viettrungluu 2010/12/29 23:41:17 Micro-nit: I think this would look nicer if you br
Avi (use Gerrit) 2010/12/30 00:04:15 Done.
+ i, IDS_ASI_URL_COLUMN));
dict->SetString("url", url_table_model_->GetURL(i).spec());
pages.Append(dict);
}
« chrome/browser/custom_home_pages_table_model.h ('K') | « chrome/browser/custom_home_pages_table_model.cc ('k') | chrome/browser/dom_ui/options/browser_options_handler.cc » ('j') | chrome/browser/notifications/notification_exceptions_table_model.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698