Remove wstring from TableModel....

chrome/browser/notifications/notification_exceptions_table_model.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_EXCEPTIONS_TABLE_MODEL_H_
 #define CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_EXCEPTIONS_TABLE_MODEL_H_
 #pragma once
 
 #include <string>

[viettrungluu, 2010/12/29 23:41:17]

I don't think it's needed.

(I don't think you need to include string16.h either. In case you are (or anyone
else is) wondering, my rule of thumb is to not include string16.h (for example)
if string16 is only used in a way which implies that string16.h must already be
included by one of our includes. In this case, we have only an override of a
method returning string16, so the superclass's header must have included
string16.h.

[Avi (use Gerrit), 2010/12/30 00:04:15]

Done.

 #include <vector>
 
+#include "base/compiler_specific.h"
 #include "chrome/browser/notifications/desktop_notification_service.h"
 #include "chrome/browser/remove_rows_table_model.h"
 #include "chrome/common/notification_observer.h"
 
 class NotificationExceptionsTableModel : public RemoveRowsTableModel,
                                          public NotificationObserver {
  public:
   explicit NotificationExceptionsTableModel(
       DesktopNotificationService* service);
   virtual ~NotificationExceptionsTableModel();
 
   // Overridden from RemoveRowsTableModel:
   virtual bool CanRemoveRows(const Rows& rows) const;
   virtual void RemoveRows(const Rows& rows);
   virtual void RemoveAll();
 
   // Overridden from TableModel:
-  virtual int RowCount();
-  virtual std::wstring GetText(int row, int column_id);
-  virtual void SetObserver(TableModelObserver* observer);
+  virtual int RowCount() OVERRIDE;
+  virtual string16 GetText(int row, int column_id) OVERRIDE;
+  virtual void SetObserver(TableModelObserver* observer) OVERRIDE;
 
   // Overridden from NotificationObserver:
   virtual void Observe(NotificationType type,
                        const NotificationSource& source,
                        const NotificationDetails& details);
  private:
   struct Entry;
 
   void LoadEntries();
 
   DesktopNotificationService* service_;
 
   typedef std::vector<Entry> EntriesVector;
   EntriesVector entries_;
 
   // We use this variable to prevent ourselves from handling further changes
   // that we ourselves caused.
   bool updates_disabled_;
   NotificationRegistrar registrar_;
   TableModelObserver* observer_;
 
   DISALLOW_COPY_AND_ASSIGN(NotificationExceptionsTableModel);
 };
 
 #endif  // CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_EXCEPTIONS_TABLE_MODEL_H_