Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Side by Side Diff: chrome/browser/notifications/notification_exceptions_table_model_unittest.cc

Issue 6044006: Remove wstring from l10n_util. Part 3.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
Property Changes:
Added: svn:eol-style
+ LF
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/notifications/notification_exceptions_table_model.h" 5 #include "chrome/browser/notifications/notification_exceptions_table_model.h"
6 6
7 #include "app/l10n_util.h" 7 #include "app/l10n_util.h"
8 #include "base/utf_string_conversions.h"
viettrungluu 2010/12/29 19:04:15 Could you mark this with a "TODO: remove when conv
Avi (use Gerrit) 2010/12/29 19:40:49 Done.
8 #include "chrome/browser/browser_thread.h" 9 #include "chrome/browser/browser_thread.h"
9 #include "chrome/browser/renderer_host/test/test_render_view_host.h" 10 #include "chrome/browser/renderer_host/test/test_render_view_host.h"
10 #include "chrome/test/testing_profile.h" 11 #include "chrome/test/testing_profile.h"
11 #include "grit/generated_resources.h" 12 #include "grit/generated_resources.h"
12 #include "testing/gtest/include/gtest/gtest.h" 13 #include "testing/gtest/include/gtest/gtest.h"
13 14
14 class NotificationExceptionsTableModelTest : public RenderViewHostTestHarness { 15 class NotificationExceptionsTableModelTest : public RenderViewHostTestHarness {
15 public: 16 public:
16 NotificationExceptionsTableModelTest() 17 NotificationExceptionsTableModelTest()
17 : ui_thread_(BrowserThread::UI, MessageLoop::current()) { 18 : ui_thread_(BrowserThread::UI, MessageLoop::current()) {
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 EXPECT_EQ(0u, service_->GetAllowedOrigins().size()); 69 EXPECT_EQ(0u, service_->GetAllowedOrigins().size());
69 EXPECT_EQ(0u, service_->GetBlockedOrigins().size()); 70 EXPECT_EQ(0u, service_->GetBlockedOrigins().size());
70 } 71 }
71 72
72 TEST_F(NotificationExceptionsTableModelTest, AlphabeticalOrder) { 73 TEST_F(NotificationExceptionsTableModelTest, AlphabeticalOrder) {
73 FillData(); 74 FillData();
74 EXPECT_EQ(5, model_->RowCount()); 75 EXPECT_EQ(5, model_->RowCount());
75 76
76 EXPECT_EQ(L"allowed.com", 77 EXPECT_EQ(L"allowed.com",
77 model_->GetText(0, IDS_EXCEPTIONS_HOSTNAME_HEADER)); 78 model_->GetText(0, IDS_EXCEPTIONS_HOSTNAME_HEADER));
78 EXPECT_EQ(l10n_util::GetString(IDS_EXCEPTIONS_ALLOW_BUTTON), 79 EXPECT_EQ(UTF16ToWideHack(
80 l10n_util::GetStringUTF16(IDS_EXCEPTIONS_ALLOW_BUTTON)),
79 model_->GetText(0, IDS_EXCEPTIONS_ACTION_HEADER)); 81 model_->GetText(0, IDS_EXCEPTIONS_ACTION_HEADER));
80 82
81 EXPECT_EQ(L"denied.com", 83 EXPECT_EQ(L"denied.com",
82 model_->GetText(1, IDS_EXCEPTIONS_HOSTNAME_HEADER)); 84 model_->GetText(1, IDS_EXCEPTIONS_HOSTNAME_HEADER));
83 EXPECT_EQ(l10n_util::GetString(IDS_EXCEPTIONS_BLOCK_BUTTON), 85 EXPECT_EQ(UTF16ToWideHack(
86 l10n_util::GetStringUTF16(IDS_EXCEPTIONS_BLOCK_BUTTON)),
84 model_->GetText(1, IDS_EXCEPTIONS_ACTION_HEADER)); 87 model_->GetText(1, IDS_EXCEPTIONS_ACTION_HEADER));
85 88
86 EXPECT_EQ(L"denied2.com", 89 EXPECT_EQ(L"denied2.com",
87 model_->GetText(2, IDS_EXCEPTIONS_HOSTNAME_HEADER)); 90 model_->GetText(2, IDS_EXCEPTIONS_HOSTNAME_HEADER));
88 EXPECT_EQ(l10n_util::GetString(IDS_EXCEPTIONS_BLOCK_BUTTON), 91 EXPECT_EQ(UTF16ToWideHack(
92 l10n_util::GetStringUTF16(IDS_EXCEPTIONS_BLOCK_BUTTON)),
89 model_->GetText(2, IDS_EXCEPTIONS_ACTION_HEADER)); 93 model_->GetText(2, IDS_EXCEPTIONS_ACTION_HEADER));
90 94
91 EXPECT_EQ(L"e-allowed2.com", 95 EXPECT_EQ(L"e-allowed2.com",
92 model_->GetText(3, IDS_EXCEPTIONS_HOSTNAME_HEADER)); 96 model_->GetText(3, IDS_EXCEPTIONS_HOSTNAME_HEADER));
93 EXPECT_EQ(l10n_util::GetString(IDS_EXCEPTIONS_ALLOW_BUTTON), 97 EXPECT_EQ(UTF16ToWideHack(
98 l10n_util::GetStringUTF16(IDS_EXCEPTIONS_ALLOW_BUTTON)),
94 model_->GetText(3, IDS_EXCEPTIONS_ACTION_HEADER)); 99 model_->GetText(3, IDS_EXCEPTIONS_ACTION_HEADER));
95 100
96 EXPECT_EQ(L"f-denied3.com", 101 EXPECT_EQ(L"f-denied3.com",
97 model_->GetText(4, IDS_EXCEPTIONS_HOSTNAME_HEADER)); 102 model_->GetText(4, IDS_EXCEPTIONS_HOSTNAME_HEADER));
98 EXPECT_EQ(l10n_util::GetString(IDS_EXCEPTIONS_BLOCK_BUTTON), 103 EXPECT_EQ(UTF16ToWideHack(
104 l10n_util::GetStringUTF16(IDS_EXCEPTIONS_BLOCK_BUTTON)),
99 model_->GetText(4, IDS_EXCEPTIONS_ACTION_HEADER)); 105 model_->GetText(4, IDS_EXCEPTIONS_ACTION_HEADER));
100 } 106 }
101 107
102 TEST_F(NotificationExceptionsTableModelTest, RemoveRows) { 108 TEST_F(NotificationExceptionsTableModelTest, RemoveRows) {
103 FillData(); 109 FillData();
104 EXPECT_EQ(5, model_->RowCount()); 110 EXPECT_EQ(5, model_->RowCount());
105 111
106 { 112 {
107 RemoveRowsTableModel::Rows rows; 113 RemoveRowsTableModel::Rows rows;
108 rows.insert(0); // allowed.com 114 rows.insert(0); // allowed.com
109 rows.insert(3); // e-allowed2.com 115 rows.insert(3); // e-allowed2.com
110 model_->RemoveRows(rows); 116 model_->RemoveRows(rows);
111 } 117 }
112 EXPECT_EQ(3, model_->RowCount()); 118 EXPECT_EQ(3, model_->RowCount());
113 EXPECT_EQ(0u, service_->GetAllowedOrigins().size()); 119 EXPECT_EQ(0u, service_->GetAllowedOrigins().size());
114 EXPECT_EQ(3u, service_->GetBlockedOrigins().size()); 120 EXPECT_EQ(3u, service_->GetBlockedOrigins().size());
115 121
116 { 122 {
117 RemoveRowsTableModel::Rows rows; 123 RemoveRowsTableModel::Rows rows;
118 rows.insert(0); 124 rows.insert(0);
119 rows.insert(1); 125 rows.insert(1);
120 rows.insert(2); 126 rows.insert(2);
121 model_->RemoveRows(rows); 127 model_->RemoveRows(rows);
122 } 128 }
123 EXPECT_EQ(0, model_->RowCount()); 129 EXPECT_EQ(0, model_->RowCount());
124 EXPECT_EQ(0u, service_->GetAllowedOrigins().size()); 130 EXPECT_EQ(0u, service_->GetAllowedOrigins().size());
125 EXPECT_EQ(0u, service_->GetBlockedOrigins().size()); 131 EXPECT_EQ(0u, service_->GetBlockedOrigins().size());
126 } 132 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698