chrome/test/automation/proxy_launcher.cc - Issue 6042009: Added WARN_UNUSED_RESULT to ScopedTempDir methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/automation/proxy_launcher.cc

Issue 6042009: Added WARN_UNUSED_RESULT to ScopedTempDir methods. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: merge with trunk Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/automation/proxy_launcher.cc

diff --git a/chrome/test/automation/proxy_launcher.cc b/chrome/test/automation/proxy_launcher.cc

index d30f21230a0f2251a20aeaf58dff311937950a7e..028849db60bcc84e0fa4a099db88f1140d3949ca 100644

--- a/chrome/test/automation/proxy_launcher.cc

+++ b/chrome/test/automation/proxy_launcher.cc

@@ -161,7 +161,8 @@ void ProxyLauncher::CloseBrowserAndServer(ShutdownType shutdown_type) {

void ProxyLauncher::LaunchBrowser(const LaunchState& state) {

if (state.clear_profile || !temp_profile_dir_.IsValid()) {

- temp_profile_dir_.Delete();

+ if (temp_profile_dir_.IsValid())

+ ASSERT_TRUE(temp_profile_dir_.Delete());

ASSERT_TRUE(temp_profile_dir_.CreateUniqueTempDir());

ASSERT_TRUE(test_launcher_utils::OverrideUserDataDir(user_data_dir()));

« no previous file with comments | « chrome/test/automation/automation_proxy_uitest.cc ('k') | chrome/test/ui_test_utils.h » ('j') | no next file with comments »