chrome/service/service_utility_process_host.cc - Issue 6042009: Added WARN_UNUSED_RESULT to ScopedTempDir methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/service/service_utility_process_host.cc

Issue 6042009: Added WARN_UNUSED_RESULT to ScopedTempDir methods. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Whitespace fix Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/service/service_utility_process_host.cc

diff --git a/chrome/service/service_utility_process_host.cc b/chrome/service/service_utility_process_host.cc

index 859e7259f2e404d2ed596e64a3d395da6837762b..4240a535077ba0b1a8da945741edc2b623a955b9 100644

--- a/chrome/service/service_utility_process_host.cc

+++ b/chrome/service/service_utility_process_host.cc

@@ -194,7 +194,8 @@ void ServiceUtilityProcessHost::Client::MetafileAvailable(

// The metafile was created in a temp folder which needs to get deleted after

// we have processed it.

ScopedTempDir scratch_metafile_dir;

- scratch_metafile_dir.Set(metafile_path.DirName());

+ if (!scratch_metafile_dir.Set(metafile_path.DirName()))

+ LOG(WARNING) << "Unable to set scratch metafile directory";

#if defined(OS_WIN)

printing::NativeMetafile metafile;

if (!metafile.CreateFromFile(metafile_path)) {