Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Side by Side Diff: chrome/browser/extensions/convert_web_app_unittest.cc

Issue 6042009: Added WARN_UNUSED_RESULT to ScopedTempDir methods. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge with trunk Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/convert_web_app.h" 5 #include "chrome/browser/extensions/convert_web_app.h"
6 6
7 #include <string> 7 #include <string>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/file_path.h" 10 #include "base/file_path.h"
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 for (size_t i = 0; i < arraysize(sizes); ++i) { 103 for (size_t i = 0; i < arraysize(sizes); ++i) {
104 GURL icon_url(web_app.app_url.Resolve(StringPrintf("%i.png", sizes[i]))); 104 GURL icon_url(web_app.app_url.Resolve(StringPrintf("%i.png", sizes[i])));
105 web_app.icons.push_back(GetIconInfo(icon_url, sizes[i])); 105 web_app.icons.push_back(GetIconInfo(icon_url, sizes[i]));
106 } 106 }
107 107
108 scoped_refptr<Extension> extension = ConvertWebAppToExtension( 108 scoped_refptr<Extension> extension = ConvertWebAppToExtension(
109 web_app, GetTestTime(1978, 12, 11, 0, 0, 0, 0)); 109 web_app, GetTestTime(1978, 12, 11, 0, 0, 0, 0));
110 ASSERT_TRUE(extension.get()); 110 ASSERT_TRUE(extension.get());
111 111
112 ScopedTempDir extension_dir; 112 ScopedTempDir extension_dir;
113 extension_dir.Set(extension->path()); 113 EXPECT_TRUE(extension_dir.Set(extension->path()));
114 114
115 EXPECT_TRUE(extension->is_app()); 115 EXPECT_TRUE(extension->is_app());
116 EXPECT_TRUE(extension->is_hosted_app()); 116 EXPECT_TRUE(extension->is_hosted_app());
117 EXPECT_FALSE(extension->is_packaged_app()); 117 EXPECT_FALSE(extension->is_packaged_app());
118 118
119 EXPECT_EQ("lJqm1+jncOHClAuwif1QxNJKfeV9Fbl9IBZx7FkNwkA=", 119 EXPECT_EQ("lJqm1+jncOHClAuwif1QxNJKfeV9Fbl9IBZx7FkNwkA=",
120 extension->public_key()); 120 extension->public_key());
121 EXPECT_EQ("ncnbaadanljoanockmphfdkimpdedemj", extension->id()); 121 EXPECT_EQ("ncnbaadanljoanockmphfdkimpdedemj", extension->id());
122 EXPECT_EQ("1978.12.11.0", extension->version()->GetString()); 122 EXPECT_EQ("1978.12.11.0", extension->version()->GetString());
123 EXPECT_EQ(UTF16ToUTF8(web_app.title), extension->name()); 123 EXPECT_EQ(UTF16ToUTF8(web_app.title), extension->name());
(...skipping 22 matching lines...) Expand all
146 WebApplicationInfo web_app; 146 WebApplicationInfo web_app;
147 web_app.manifest_url = GURL("http://aaronboodman.com/gearpad/manifest.json"); 147 web_app.manifest_url = GURL("http://aaronboodman.com/gearpad/manifest.json");
148 web_app.title = ASCIIToUTF16("Gearpad"); 148 web_app.title = ASCIIToUTF16("Gearpad");
149 web_app.app_url = GURL("http://aaronboodman.com/gearpad/"); 149 web_app.app_url = GURL("http://aaronboodman.com/gearpad/");
150 150
151 scoped_refptr<Extension> extension = ConvertWebAppToExtension( 151 scoped_refptr<Extension> extension = ConvertWebAppToExtension(
152 web_app, GetTestTime(1978, 12, 11, 0, 0, 0, 0)); 152 web_app, GetTestTime(1978, 12, 11, 0, 0, 0, 0));
153 ASSERT_TRUE(extension.get()); 153 ASSERT_TRUE(extension.get());
154 154
155 ScopedTempDir extension_dir; 155 ScopedTempDir extension_dir;
156 extension_dir.Set(extension->path()); 156 EXPECT_TRUE(extension_dir.Set(extension->path()));
157 157
158 EXPECT_TRUE(extension->is_app()); 158 EXPECT_TRUE(extension->is_app());
159 EXPECT_TRUE(extension->is_hosted_app()); 159 EXPECT_TRUE(extension->is_hosted_app());
160 EXPECT_FALSE(extension->is_packaged_app()); 160 EXPECT_FALSE(extension->is_packaged_app());
161 161
162 EXPECT_EQ("lJqm1+jncOHClAuwif1QxNJKfeV9Fbl9IBZx7FkNwkA=", 162 EXPECT_EQ("lJqm1+jncOHClAuwif1QxNJKfeV9Fbl9IBZx7FkNwkA=",
163 extension->public_key()); 163 extension->public_key());
164 EXPECT_EQ("ncnbaadanljoanockmphfdkimpdedemj", extension->id()); 164 EXPECT_EQ("ncnbaadanljoanockmphfdkimpdedemj", extension->id());
165 EXPECT_EQ("1978.12.11.0", extension->version()->GetString()); 165 EXPECT_EQ("1978.12.11.0", extension->version()->GetString());
166 EXPECT_EQ(UTF16ToUTF8(web_app.title), extension->name()); 166 EXPECT_EQ(UTF16ToUTF8(web_app.title), extension->name());
167 EXPECT_EQ("", extension->description()); 167 EXPECT_EQ("", extension->description());
168 EXPECT_EQ(web_app.app_url, extension->GetFullLaunchURL()); 168 EXPECT_EQ(web_app.app_url, extension->GetFullLaunchURL());
169 EXPECT_EQ(0u, extension->icons().map().size()); 169 EXPECT_EQ(0u, extension->icons().map().size());
170 EXPECT_EQ(0u, extension->api_permissions().size()); 170 EXPECT_EQ(0u, extension->api_permissions().size());
171 ASSERT_EQ(1u, extension->web_extent().patterns().size()); 171 ASSERT_EQ(1u, extension->web_extent().patterns().size());
172 EXPECT_EQ("*://aaronboodman.com/*", 172 EXPECT_EQ("*://aaronboodman.com/*",
173 extension->web_extent().patterns()[0].GetAsString()); 173 extension->web_extent().patterns()[0].GetAsString());
174 } 174 }
OLDNEW
« no previous file with comments | « base/scoped_temp_dir_unittest.cc ('k') | chrome/browser/extensions/extension_websocket_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698