Added WARN_UNUSED_RESULT to ScopedTempDir methods.

chrome/service/service_utility_process_host.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/service/service_utility_process_host.h"
 
 #include "app/app_switches.h"
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/message_loop.h"
@@ skipping 176 matching lines @@
   IPC_END_MESSAGE_MAP_EX()
   return handled;
 }
 
 void ServiceUtilityProcessHost::Client::MetafileAvailable(
     const FilePath& metafile_path,
     int highest_rendered_page_number) {
   // The metafile was created in a temp folder which needs to get deleted after
   // we have processed it.
   ScopedTempDir scratch_metafile_dir;
-  scratch_metafile_dir.Set(metafile_path.DirName());
+  if (!scratch_metafile_dir.Set(metafile_path.DirName())) {

[sanjeevr, 2011/01/07 04:38:57]

The only use to the scratch_metafile_dir is to delete the temp folder. We really
do not want to do any error checking on this. If metafile_path is invalid, the
CreateFromFile call below will fail.

[cbentzel, 2011/01/10 14:14:36]

Moved to LOG(WARNING) and fallthrough in this case.

+    // This will happen if metafile_path is invalid. It could potentially
+    // be strengthened to a CHECK.
+    OnRenderPDFPagesToMetafileFailed();
+    return;
+  }
 #if defined(OS_WIN)
   printing::NativeMetafile metafile;
   if (!metafile.CreateFromFile(metafile_path)) {
     OnRenderPDFPagesToMetafileFailed();
   } else {
     OnRenderPDFPagesToMetafileSucceeded(metafile, highest_rendered_page_number);
     // Close it so that ScopedTempDir can delete the folder.
     metafile.CloseEmf();
   }
 #endif  // defined(OS_WIN)
 }