Issue 6041007: Move rgs_helper out of base to ceee since it's not used anywhere else....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6041007: Move rgs_helper out of base to ceee since it's not used anywhere else.... (Closed)

Created:
9 years, 12 months ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
MAD, Sigurður Ásgeirsson

CC:
chromium-reviews, brettw-cc_chromium.org, ceee-reviews_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Move rgs_helper out of base to ceee since it's not used anywhere else. TEST=it compiles BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70280

Created: 9 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -97 lines)			Patch
M	base/base.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download
D	base/win/rgs_helper.h	View		1 chunk	+0 lines, -89 lines	0 comments	Download
M	ceee/ie/broker/broker.h	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	ceee/ie/common/rgs_helper.h	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	ceee/ie/ie.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ceee/ie/plugin/bho/browser_helper_object.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ceee/ie/plugin/bho/executor.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ceee/ie/plugin/toolband/tool_band.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

brettw

I don't think rgs_helper should have been put in base since it's rather specific (I ...

9 years, 12 months ago (2010-12-29 21:53:16 UTC) #1

TBR