Issue 6041005: Add implementation of WebThemeEngine for the Mac (declared by...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6041005: Add implementation of WebThemeEngine for the Mac (declared by... (Closed)

Created:
10 years ago by Mihai Parparita -not on Chrome

Modified:
9 years, 6 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, pam+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add implementation of WebThemeEngine for the Mac (declared by http://webkit.org/b/51507). This allows scrollbar thumb rendering to be overridden, so that we can match the Mac port's when running under the DRT. BUG=23498 TEST=Layout tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70278

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+89 lines, -2 lines)			Patch
M	webkit/glue/webkit_glue.gypi	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	webkit/glue/webkitclient_impl.h	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	webkit/glue/webkitclient_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A	webkit/glue/webthemeengine_impl_mac.h	View	1 chunk	+25 lines, -0 lines	0 comments	Download
A	webkit/glue/webthemeengine_impl_mac.cc	View	1 chunk	+56 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

LGTM http://codereview.chromium.org/6041005/diff/7001/webkit/glue/webthemeengine_impl_mac.cc File webkit/glue/webthemeengine_impl_mac.cc (right): http://codereview.chromium.org/6041005/diff/7001/webkit/glue/webthemeengine_impl_mac.cc#newcode7 webkit/glue/webthemeengine_impl_mac.cc:7: #include <Carbon/Carbon.h> nit: we usually put a new ...

10 years ago (2010-12-23 07:24:24 UTC) #2

Mihai Parparita -not on Chrome

9 years, 12 months ago (2010-12-29 21:26:38 UTC) #3

On Wed, Dec 22, 2010 at 11:24 PM,  <darin@chromium.org> wrote:
>
http://codereview.chromium.org/6041005/diff/7001/webkit/glue/webthemeengine_i...
> webkit/glue/webthemeengine_impl_mac.cc:7: #include <Carbon/Carbon.h>
> nit: we usually put a new line between system headers and others.

Fixed.

>
http://codereview.chromium.org/6041005/diff/7001/webkit/glue/webthemeengine_i...
> webkit/glue/webthemeengine_impl_mac.cc:56: }  // namespace webkit_glue
> nit: add a new line above here.

Fixed.

Mihai

Expand Messages | Collapse Messages