Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 6041004: net: perform a non-A DNS lookup for HTTPS hosts. (Closed)

Created:
9 years, 12 months ago by agl
Modified:
9 years, 7 months ago
Reviewers:
Mike Belshe, mbelshe
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

net: perform a non-A DNS lookup for HTTPS hosts. Since SSLHostInfo is enabled by default now, this will cause a DNS lookup for a random RR type (13172) for each HTTPS host. (Although many of these lookups will hit the in-process cache. Also, this won't do anything on non-Linux machines because I haven't gotten the DNS lookup code working on them yet.) At some point in the future we'll probably want to do these lookups in order to get information for certificate validation. This change just exists so that we can measure how long these lookups take. BUG=none TEST=none

Patch Set 1 #

Patch Set 2 : ... #

Total comments: 2

Patch Set 3 : Add missing UMA_ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -2 lines) Patch
M net/base/dns_util.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/socket/ssl_client_socket_pool.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/socket/ssl_host_info.h View 4 chunks +14 lines, -0 lines 0 comments Download
M net/socket/ssl_host_info.cc View 1 2 3 chunks +33 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
agl
9 years, 12 months ago (2010-12-22 19:45:06 UTC) #1
agl
ping
9 years, 11 months ago (2011-01-06 17:36:45 UTC) #2
Mike Belshe
http://codereview.chromium.org/6041004/diff/2001/net/socket/ssl_host_info.cc File net/socket/ssl_host_info.cc (right): http://codereview.chromium.org/6041004/diff/2001/net/socket/ssl_host_info.cc#newcode227 net/socket/ssl_host_info.cc:227: HISTOGRAM_TIMES("Net.SSLHostInfoDNSLookup", elapsed); Do you want this to be UMA_HISTOGRAM_TIMES? ...
9 years, 11 months ago (2011-01-06 17:51:06 UTC) #3
agl
PTAL http://codereview.chromium.org/6041004/diff/2001/net/socket/ssl_host_info.cc File net/socket/ssl_host_info.cc (right): http://codereview.chromium.org/6041004/diff/2001/net/socket/ssl_host_info.cc#newcode227 net/socket/ssl_host_info.cc:227: HISTOGRAM_TIMES("Net.SSLHostInfoDNSLookup", elapsed); On 2011/01/06 17:51:06, Mike Belshe wrote: ...
9 years, 11 months ago (2011-01-06 18:12:08 UTC) #4
mbelshe
9 years, 11 months ago (2011-01-06 18:20:11 UTC) #5
Lgtm
On Jan 6, 2011 10:12 AM, <agl@chromium.org> wrote:
> PTAL
>
>
>
http://codereview.chromium.org/6041004/diff/2001/net/socket/ssl_host_info.cc
> File net/socket/ssl_host_info.cc (right):
>
>
http://codereview.chromium.org/6041004/diff/2001/net/socket/ssl_host_info.cc#...
> net/socket/ssl_host_info.cc:227:
> HISTOGRAM_TIMES("Net.SSLHostInfoDNSLookup", elapsed);
> On 2011/01/06 17:51:06, Mike Belshe wrote:
>> Do you want this to be UMA_HISTOGRAM_TIMES? (I think so)
>
> Opps, yes, thanks.
>
> http://codereview.chromium.org/6041004/

Powered by Google App Engine
This is Rietveld 408576698