Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 6041002: Implicitly detect the use of --in-process-webgl by the absence of a... (Closed)

Created:
10 years ago by Ken Russell (switch to Gerrit)
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Implicitly detect the use of --in-process-webgl by the absence of a display connection in x11_util, and open our own display instead. This makes --in-process-webgl work on Linux again. Tested by running some WebGL and accelerated 2D Canvas content with --in-process-webgl and --disable-accelerated-compositing. BUG=55152 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69892

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -18 lines) Patch
M app/gfx/gl/gl_context_linux.cc View 19 chunks +39 lines, -18 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
Ken Russell (switch to Gerrit)
Please review. Thanks.
10 years ago (2010-12-21 22:19:04 UTC) #1
Vangelis Kokkevis
LGTM
10 years ago (2010-12-21 22:42:04 UTC) #2
greggman
lgtm http://codereview.chromium.org/6041002/diff/1/app/gfx/gl/gl_context_linux.cc File app/gfx/gl/gl_context_linux.cc (right): http://codereview.chromium.org/6041002/diff/1/app/gfx/gl/gl_context_linux.cc#newcode28 app/gfx/gl/gl_context_linux.cc:28: static Display* display = NULL; I'll assume this ...
10 years ago (2010-12-21 22:47:01 UTC) #3
Ken Russell (switch to Gerrit)
10 years ago (2010-12-21 22:49:59 UTC) #4
http://codereview.chromium.org/6041002/diff/1/app/gfx/gl/gl_context_linux.cc
File app/gfx/gl/gl_context_linux.cc (right):

http://codereview.chromium.org/6041002/diff/1/app/gfx/gl/gl_context_linux.cc#...
app/gfx/gl/gl_context_linux.cc:28: static Display* display = NULL;
On 2010/12/21 22:47:01, greggman wrote:
> I'll assume this works with multiple display, as in this will never change
once
> queried.

Not sure. It'll work as well as x11_util::GetXDisplay() since that uses a static
variable too.

Powered by Google App Engine
This is Rietveld 408576698