Issue 604062: Inline NumberToString...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 604062: Inline NumberToString... (Closed)

Created:
10 years, 10 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Inline NumberToString NumberToString in runtime JavaScript is inlined through a call to a stub. Currently the stub only checks the number string cache and only if the number is a smi. Code is shared with the inlining of number string cache lookup when adding a smi to a string. Committed: http://code.google.com/p/v8/source/detail?r=3865

Patch Set 1 #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+154 lines, -36 lines)			Patch
M	src/arm/codegen-arm.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/arm/codegen-arm.cc	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	src/code-stubs.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/codegen.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/heap.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/ia32/codegen-ia32.h	View	2 chunks	+36 lines, -0 lines	0 comments	Download
M	src/ia32/codegen-ia32.cc	View	3 chunks	+82 lines, -31 lines	0 comments	Download
M	src/runtime.js	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/v8-counters.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/x64/codegen-x64.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

10 years, 10 months ago (2010-02-16 09:21:20 UTC) #2

LGTM, please file bug to port the stub to the other platforms.

Expand Messages | Collapse Messages