Issue 604061: Roll gyp DEPS, and mostly revert r38366 which was fixed better in gyp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 604061: Roll gyp DEPS, and mostly revert r38366 which was fixed better in gyp. (Closed)

Created:
10 years, 10 months ago by Michael Moss

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang, bradnelson, Evan Martin

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Roll gyp DEPS, and mostly revert r38366 which was fixed better in gyp. This properly triggers build targets that depend on "always run" actions. BUG=22044

Patch Set 1 #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -13 lines)			Patch
M	DEPS	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/base.gyp	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	build/util/build_util.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/chrome.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/installer/installer.gyp	View	4 chunks	+2 lines, -6 lines	0 comments	Download
M	chrome/installer/mini_installer.gyp	View	1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Moss

This brings in a gyp change which should be a more complete fix for the ...

10 years, 10 months ago (2010-02-16 05:47:45 UTC) #1

LGTM

Expand Messages | Collapse Messages