Vboot Reference: Move test key generation to a separate script and add sample test keys.

Vboot Reference: Move test key generation to a separate script and add sample test keys.

Key generation takes a long time. This will be useful in driving the cryptosuite through autotest.

[gauravsh, 2010-02-11 03:26:00]

Ignore the previous review, use this instead. I deleted my local git branch
associated with that issue by mistake. :)

[petkov, 2010-02-11 05:30:20]

A few nits.

http://codereview.chromium.org/604016/diff/2001/3001
File src/platform/vboot_reference/tests/Makefile (right):

http://codereview.chromium.org/604016/diff/2001/3001#newcode6
src/platform/vboot_reference/tests/Makefile:6: CFLAGS=-Wall -ansi
No spaces around = in the style? Don't know...

http://codereview.chromium.org/604016/diff/2001/3001#newcode11
src/platform/vboot_reference/tests/Makefile:11: OBJS=$(SRCS:.c=.o)
You don't really use OBJS/SRCS below.

http://codereview.chromium.org/604016/diff/2001/3001#newcode14
src/platform/vboot_reference/tests/Makefile:14: tests:	sha_tests
Change 2 spaces to 1

http://codereview.chromium.org/604016/diff/2001/3001#newcode20
src/platform/vboot_reference/tests/Makefile:20: rm -f $(OBJS) sha_tests
You build the binary directly so no need for OBJS.

http://codereview.chromium.org/604016/diff/2001/3003
File src/platform/vboot_reference/tests/run_tests.sh (right):

http://codereview.chromium.org/604016/diff/2001/3003#newcode26
src/platform/vboot_reference/tests/run_tests.sh:26: -pkcs -inkey
${KEY_DIR}/key_rsa${keylen}.pem > $1.rsa${keylen}\_${hashalgo}.sig
indent further? 80 chars

http://codereview.chromium.org/604016/diff/2001/3003#newcode39
src/platform/vboot_reference/tests/run_tests.sh:39: ${UTIL_DIR}/verify_data
$algorithmcounter ${KEY_DIR}/key_rsa${keylen}.keyb \
80 chars

[gauravsh, 2010-02-11 05:43:44]

http://codereview.chromium.org/604016/diff/2001/3001
File src/platform/vboot_reference/tests/Makefile (right):

http://codereview.chromium.org/604016/diff/2001/3001#newcode6
src/platform/vboot_reference/tests/Makefile:6: CFLAGS=-Wall -ansi
On 2010/02/11 05:30:21, petkov wrote:
> No spaces around = in the style? Don't know...

I have seen both styles used. But I think spaces are base. Changed.

http://codereview.chromium.org/604016/diff/2001/3001#newcode11
src/platform/vboot_reference/tests/Makefile:11: OBJS=$(SRCS:.c=.o)
On 2010/02/11 05:30:21, petkov wrote:
> You don't really use OBJS/SRCS below.
Removed.

http://codereview.chromium.org/604016/diff/2001/3001#newcode14
src/platform/vboot_reference/tests/Makefile:14: tests:	sha_tests
On 2010/02/11 05:30:21, petkov wrote:
> Change 2 spaces to 1
> 

Done.

http://codereview.chromium.org/604016/diff/2001/3001#newcode20
src/platform/vboot_reference/tests/Makefile:20: rm -f $(OBJS) sha_tests
On 2010/02/11 05:30:21, petkov wrote:
> You build the binary directly so no need for OBJS.
> 
Done.

http://codereview.chromium.org/604016/diff/2001/3003
File src/platform/vboot_reference/tests/run_tests.sh (right):

http://codereview.chromium.org/604016/diff/2001/3003#newcode26
src/platform/vboot_reference/tests/run_tests.sh:26: -pkcs -inkey
${KEY_DIR}/key_rsa${keylen}.pem > $1.rsa${keylen}\_${hashalgo}.sig
On 2010/02/11 05:30:21, petkov wrote:
> indent further? 80 chars
done.

http://codereview.chromium.org/604016/diff/2001/3003#newcode39
src/platform/vboot_reference/tests/run_tests.sh:39: ${UTIL_DIR}/verify_data
$algorithmcounter ${KEY_DIR}/key_rsa${keylen}.keyb \
On 2010/02/11 05:30:21, petkov wrote:
> 80 chars
done.

[petkov, 2010-02-11 06:32:01]

LGTM

http://codereview.chromium.org/604016/diff/6001/6002
File src/platform/vboot_reference/tests/Makefile (right):

http://codereview.chromium.org/604016/diff/6001/6002#newcode10
src/platform/vboot_reference/tests/Makefile:10: LIBS=$(TOP)/crypto/libcrypto.a
$(TOP)/common/libcommon.a
spaces around = then.

http://codereview.chromium.org/604016/diff/6001/6004
File src/platform/vboot_reference/tests/run_tests.sh (right):

http://codereview.chromium.org/604016/diff/6001/6004#newcode27
src/platform/vboot_reference/tests/run_tests.sh:27: >
$1.rsa${keylen}\_${hashalgo}.sig
Is the \ in \_ necessary?

[gauravsh, 2010-02-11 07:06:53]

Fixed your comments below. Committing..

http://codereview.chromium.org/604016/diff/6001/6002
File src/platform/vboot_reference/tests/Makefile (right):

http://codereview.chromium.org/604016/diff/6001/6002#newcode10
src/platform/vboot_reference/tests/Makefile:10: LIBS=$(TOP)/crypto/libcrypto.a
$(TOP)/common/libcommon.a
On 2010/02/11 06:32:01, petkov wrote:
> spaces around = then.
Done.

http://codereview.chromium.org/604016/diff/6001/6004
File src/platform/vboot_reference/tests/run_tests.sh (right):

http://codereview.chromium.org/604016/diff/6001/6004#newcode27
src/platform/vboot_reference/tests/run_tests.sh:27: >
$1.rsa${keylen}\_${hashalgo}.sig
On 2010/02/11 06:32:01, petkov wrote:
> Is the \ in \_ necessary?
> 

No, fixed.