Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 6040002: Remove more 'using' declarations of Scoped* from scoped_handle_win.h (Closed)

Created:
10 years ago by tfarina
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Remove more 'using' declarations of Scoped* from scoped_handle_win.h BUG=None TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70286

Patch Set 1 #

Patch Set 2 : also remove ScopedRegion #

Patch Set 3 : fix linux_chromeos #

Patch Set 4 : fix bots again #

Patch Set 5 : fix linux_view and linux_chromeos #

Total comments: 2

Patch Set 6 : typedef #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -17 lines) Patch
M app/win_util.cc View 2 chunks +2 lines, -1 line 0 comments Download
M base/scoped_handle_win.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/aeropeek_manager.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/tabs/dock_info_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/dropdown_bar_host.cc View 1 2 3 4 5 6 chunks +18 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/status_icons/status_icon_win.h View 2 chunks +2 lines, -2 lines 0 comments Download
M views/view.cc View 1 2 3 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
Please, take a look.
10 years ago (2010-12-23 13:06:50 UTC) #1
tfarina
ping?
10 years ago (2010-12-23 20:47:53 UTC) #2
brettw
http://codereview.chromium.org/6040002/diff/8001/chrome/browser/ui/views/dropdown_bar_host.cc File chrome/browser/ui/views/dropdown_bar_host.cc (right): http://codereview.chromium.org/6040002/diff/8001/chrome/browser/ui/views/dropdown_bar_host.cc#newcode216 chrome/browser/ui/views/dropdown_bar_host.cc:216: #if defined(OS_WIN) All of these new ifdefs in this ...
9 years, 12 months ago (2010-12-29 20:40:34 UTC) #3
tfarina
http://codereview.chromium.org/6040002/diff/8001/chrome/browser/ui/views/dropdown_bar_host.cc File chrome/browser/ui/views/dropdown_bar_host.cc (right): http://codereview.chromium.org/6040002/diff/8001/chrome/browser/ui/views/dropdown_bar_host.cc#newcode216 chrome/browser/ui/views/dropdown_bar_host.cc:216: #if defined(OS_WIN) On 2010/12/29 20:40:34, brettw wrote: > All ...
9 years, 12 months ago (2010-12-29 20:58:06 UTC) #4
brettw
9 years, 12 months ago (2010-12-29 21:04:28 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698