Issue 6039002: Tweak quicksort loop to reduce number of compares slightly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6039002: Tweak quicksort loop to reduce number of compares slightly. (Closed)

Created:
10 years ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Karl Klose

CC:
v8-dev

Visibility:
Public.

Description

Tweak quicksort loop to reduce number of compares slightly.

Patch Set 1 #

Total comments: 6

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -12 lines)			Patch
	M	src/array.js	View		3 chunks	+18 lines, -12 lines	4 comments	Download
	M	test/mjsunit/array-sort.js	View		1 chunk	+15 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Karl Klose

LGTM http://codereview.chromium.org/6039002/diff/1/src/array.js File src/array.js (right): http://codereview.chromium.org/6039002/diff/1/src/array.js#newcode1 src/array.js:1: // Copyright 2006-2008 the V8 project authors. All ...

10 years ago (2010-12-20 14:28:43 UTC) #2

Lasse Reichstein

10 years ago (2010-12-20 15:00:59 UTC) #3

http://codereview.chromium.org/6039002/diff/1/src/array.js
File src/array.js (right):

http://codereview.chromium.org/6039002/diff/1/src/array.js#newcode1
src/array.js:1: // Copyright 2006-2008 the V8 project authors. All rights
reserved.
Will do.

http://codereview.chromium.org/6039002/diff/1/src/array.js#newcode724
src/array.js:724: partition: for (var i = low_end + 1; i < high_start; ) {
Good point!

http://codereview.chromium.org/6039002/diff/1/test/mjsunit/array-sort.js
File test/mjsunit/array-sort.js (right):

http://codereview.chromium.org/6039002/diff/1/test/mjsunit/array-sort.js#newc...
test/mjsunit/array-sort.js:1: // Copyright 2008 the V8 project authors. All
rights reserved.
Done.

Expand Messages | Collapse Messages