Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 6037016: Fix incorrect assertion following the move of Geolocation provider in to its own thread. (Closed)

Created:
9 years, 11 months ago by John Knottenbelt
Modified:
9 years, 7 months ago
Reviewers:
bulach
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Fix incorrect assertion following the move of Geolocation provider in to its own thread. Change r61182 <http://crrev.com/61182>; moved the geolocation providers on to their own "Geolocation" thread. The experimental CoreLocation provider needs to be changed accordingly to send position updates to the Geolocation thread instead of browser thread. BUG=67311 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70615

Patch Set 1 #

Total comments: 6

Patch Set 2 : Fix nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -20 lines) Patch
M chrome/browser/geolocation/core_location_data_provider_mac.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/geolocation/core_location_data_provider_mac.mm View 1 10 chunks +19 lines, -15 lines 0 comments Download
M chrome/browser/geolocation/core_location_provider_mac.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/geolocation/core_location_provider_mac.mm View 1 3 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
bulach
9 years, 11 months ago (2011-01-06 12:44:59 UTC) #1
LGTM

sorry about the delay, and thanks for the fix!
just some nits below:

http://codereview.chromium.org/6037016/diff/1/chrome/browser/geolocation/core...
File chrome/browser/geolocation/core_location_data_provider_mac.mm (right):

http://codereview.chromium.org/6037016/diff/1/chrome/browser/geolocation/core...
chrome/browser/geolocation/core_location_data_provider_mac.mm:187:
if(MessageLoop::current() != GeolocationProvider::GetInstance()->message_loop())
nit:space after if, and >80cols

if (MessageLoop::current() !=
    GeolocationProvider::GetInstance()->message_loop()) {
}

http://codereview.chromium.org/6037016/diff/1/chrome/browser/geolocation/core...
chrome/browser/geolocation/core_location_data_provider_mac.mm:189: "CoreLocation
data provider must be created on the Geolocation thread.";
nit: >80cols.

http://codereview.chromium.org/6037016/diff/1/chrome/browser/geolocation/core...
chrome/browser/geolocation/core_location_data_provider_mac.mm:198: // location
services are enabled.  The pointer toargument will only be accessed
s/to//

http://codereview.chromium.org/6037016/diff/1/chrome/browser/geolocation/core...
chrome/browser/geolocation/core_location_data_provider_mac.mm:239:
DCHECK(MessageLoop::current() ==
GeolocationProvider::GetInstance()->message_loop());
nit: >80cols

http://codereview.chromium.org/6037016/diff/1/chrome/browser/geolocation/core...
File chrome/browser/geolocation/core_location_provider_mac.mm (right):

http://codereview.chromium.org/6037016/diff/1/chrome/browser/geolocation/core...
chrome/browser/geolocation/core_location_provider_mac.mm:24: // StartProvider
maybe called multiple times (e.g. to update the high_accuracy hint)
>80cols

http://codereview.chromium.org/6037016/diff/1/chrome/browser/geolocation/core...
chrome/browser/geolocation/core_location_provider_mac.mm:53: if
(CommandLine::ForCurrentProcess()
I think a more natural break would be:
if (CommandLine::ForCurrentProcess()->HasSwitch(
    switches::kExperimentalLocationFeatures)) {
}

Powered by Google App Engine
This is Rietveld 408576698