Issue 6037013: net: Add namespace net to URLRequestFilter.

Issue 6037013: net: Add namespace net to URLRequestFilter. (Closed)

Created:
9 years, 12 months ago by tfarina

Modified:
9 years, 7 months ago

Reviewers:
wtc, willchan no longer on Chromium

CC:
chromium-reviews, cbentzel+watch_chromium.org, nkostylev+cc_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

net: Add namespace net to URLRequestFilter. BUG=64263 TEST=compiled locally and trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70180

Patch Set 1 #

Total comments: 1

Created: 9 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -40 lines)			Patch
M	chrome/browser/automation/automation_resource_message_filter.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/account_screen_browsertest.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/login/registration_screen.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/registration_screen.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/net/url_request_failed_dns_job.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/net/url_request_failed_dns_job.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/net/url_request_mock_http_job.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/net/url_request_mock_http_job.cc	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/net/url_request_mock_link_doctor_job.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/net/url_request_mock_link_doctor_job.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/net/url_request_mock_net_error_job.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/net/url_request_mock_util.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/net/url_request_slow_download_job.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/net/url_request_slow_download_job.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/net/url_request_slow_http_job.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/net/url_request_slow_http_job.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/printing/print_dialog_cloud_uitest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	net/url_request/url_request_filter.h	View	2 chunks	+2 lines, -1 line	1 comment	Download
M	net/url_request/url_request_filter.cc	View	2 chunks	+6 lines, -2 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

wtc

9 years, 11 months ago (2011-01-04 23:00:39 UTC) #3

tfarina: I only reviewed your changes to
net/url_request/url_request_filter.{h,cc}.  I have just one
nit.

http://codereview.chromium.org/6037013/diff/1/net/url_request/url_request_fil...
File net/url_request/url_request_filter.h (right):

http://codereview.chromium.org/6037013/diff/1/net/url_request/url_request_fil...
net/url_request/url_request_filter.h:38: net::URLRequest::ProtocolFactory*>
HostnameHandlerMap;
You can remove net:: inside the net namespace.

This comment also applies to net/url_request/url_request_filter.cc.

Expand Messages | Collapse Messages