Mac: trivial clean up of tab strip layout code + unseeable layout fix.

Mac: trivial clean up of tab strip layout code + unseeable layout fix.

The placement of the new tab button was wrong when a placeholder is present ...
but in that case the new tab button wasn't shown.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70296

[viettrungluu, 2010-12-30 03:07:42]

Doing trivial things to code I'm about to completely rewrite....

[Nico, 2010-12-30 03:56:06]

LG with nit.

Why are you about to rewrite this? If the answer is "just because", I'd say
don't. If the answer is better, then there should be a bug for that, and this CL
could reference it :-)

http://codereview.chromium.org/6036005/diff/1/chrome/browser/ui/cocoa/tab_str...
File chrome/browser/ui/cocoa/tab_strip_controller.mm (right):

http://codereview.chromium.org/6036005/diff/1/chrome/browser/ui/cocoa/tab_str...
chrome/browser/ui/cocoa/tab_strip_controller.mm:910: NSMakePoint(MAX(offset,
NSMaxX(placeholderFrame_) - kTabOverlap) +
As you would say, "I hate this formatting". Maybe introduce a variable for some
subexpression for x (maybe for |NSMaxX(placeholderFrame_) - kTabOverlap| or
|MAX(offset, NSMaxX(placeholderFrame_) - kTabOverlap)|, and then have one line
for x and one for y.

[viettrungluu, 2010-12-30 05:07:20]

I have my reasons for wanting to rewrite this. I'd tell you, but then I'd have
to kill you. (I'll tell you if that's okay with you. Or you can just wait for
the next CL.)

http://codereview.chromium.org/6036005/diff/1/chrome/browser/ui/cocoa/tab_str...
File chrome/browser/ui/cocoa/tab_strip_controller.mm (right):

http://codereview.chromium.org/6036005/diff/1/chrome/browser/ui/cocoa/tab_str...
chrome/browser/ui/cocoa/tab_strip_controller.mm:910: NSMakePoint(MAX(offset,
NSMaxX(placeholderFrame_) - kTabOverlap) +
On 2010/12/30 03:56:06, Nico wrote:
> As you would say, "I hate this formatting". Maybe introduce a variable for
some
> subexpression for x (maybe for |NSMaxX(placeholderFrame_) - kTabOverlap| or
> |MAX(offset, NSMaxX(placeholderFrame_) - kTabOverlap)|, and then have one line
> for x and one for y.

Done. I hated the formatting too. Ironically, introducing a variable allowed me
to fit it on only two lines (sensibly).