Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 6035016: Added a few new debugger tests. (Closed)

Created:
9 years, 11 months ago by marklam
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Added a few new debugger tests. Committed: http://code.google.com/p/v8/source/detail?r=6222

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+329 lines, -0 lines) Patch
A test/mjsunit/debug-listbreakpoints.js View 1 chunk +210 lines, -0 lines 0 comments Download
A test/mjsunit/debug-setexceptionbreak.js View 1 chunk +119 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
marklam
Hi Søren, Here are 2 new debugger unit tests that test the functionality of listbreakpoints ...
9 years, 11 months ago (2011-01-06 04:28:19 UTC) #1
Søren Thygesen Gjesse
9 years, 11 months ago (2011-01-07 12:01:14 UTC) #2
LGTM

Committed: http://code.google.com/p/v8/source/detail?r=6222

Regarding the gc and setflags requests you could just add sanity checks that the
requests are recognized and return a response with the expected properties.

Powered by Google App Engine
This is Rietveld 408576698