Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: src/runtime.cc

Issue 6035014: First cut at bug 992 (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Format to 80 columns Created 9 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/v8natives.js » ('j') | src/v8natives.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/runtime.cc
diff --git a/src/runtime.cc b/src/runtime.cc
index 724a4363483e0aa3a806f73cdb8a24fa8958441f..d28fbc705d9235ff01ba03442da68d0e01fc2d2b 100644
--- a/src/runtime.cc
+++ b/src/runtime.cc
@@ -3493,7 +3493,12 @@ static MaybeObject* Runtime_KeyedGetProperty(Arguments args) {
args.at<Object>(1));
}
-
+// Implements part of 8.12.9 DefinePropertyAccessor
Rico 2011/01/05 13:37:01 DefinePropertyAccessor -> DefineOwnProperty
Peter Hallam 2011/01/05 23:50:31 Done.
+// There are 3 cases that lead here:
+// Step 4b - defining a new accessor property
Rico 2011/01/05 13:37:01 Period at end of the comment + below and above
Peter Hallam 2011/01/05 23:50:31 Done.
+// Steps 9c & 12 - replacing an existing data property with an accessor property
+// Step 12 - updating an existing accessor property with an accessor or generic
+// descriptor
static MaybeObject* Runtime_DefineOrRedefineAccessorProperty(Arguments args) {
ASSERT(args.length() == 5);
HandleScope scope;
@@ -3525,6 +3530,12 @@ static MaybeObject* Runtime_DefineOrRedefineAccessorProperty(Arguments args) {
return obj->DefineAccessor(name, flag_setter->value() == 0, fun, attr);
}
+// Implements part of 8.12.9 DefineOwnProperty
Rico 2011/01/05 13:37:01 Period at end of comment + below
Peter Hallam 2011/01/05 23:50:31 Done.
+// There are 3 cases that lead here:
+// Step 4a - defining a new data property
+// Steps 9b & 12 - replacing an existing accessor property with a data property
+// Step 12 - updating an existing data property with a data or generic
+// descriptor
static MaybeObject* Runtime_DefineOrRedefineDataProperty(Arguments args) {
ASSERT(args.length() == 4);
HandleScope scope;
« no previous file with comments | « no previous file | src/v8natives.js » ('j') | src/v8natives.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698