Issue 6035007: Don't run DecoderVp8Test.EncodeAndDecode under Dr.Memory...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6035007: Don't run DecoderVp8Test.EncodeAndDecode under Dr.Memory... (Closed)

Created:
10 years ago by Timur Iskhodzhanov

Modified:
9 years, 6 months ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Don't run DecoderVp8Test.EncodeAndDecode under Dr.Memory Also temporary enable leak checking to see the how many leaks does DrM find on the Chromium tests. BUG=57266 TBR=glider Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70153

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	tools/valgrind/gtest_exclude/remoting_unittests.gtest-drmemory_win32.txt	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	tools/valgrind/valgrind_test.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Alexander Potapenko

9 years, 12 months ago (2010-12-28 08:12:40 UTC) #2

LGTM

On Fri, Dec 24, 2010 at 2:09 PM,  <timurrrr@chromium.org> wrote:
> Reviewers: Alexander Potapenko,
>
> Description:
> Don't run DecoderVp8Test.EncodeAndDecode under Dr.Memory
> Also temporary enable leak checking to see the how many leaks does DrM find
> on
> the Chromium tests.
> BUG=57266
> TBR=glider
>
> Please review this at http://codereview.chromium.org/6035007/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M
> tools/valgrind/gtest_exclude/remoting_unittests.gtest-drmemory_win32.txt
>  M     tools/valgrind/valgrind_test.py
>
>
> Index:
> tools/valgrind/gtest_exclude/remoting_unittests.gtest-drmemory_win32.txt
> ===================================================================
> --- tools/valgrind/gtest_exclude/remoting_unittests.gtest-drmemory_win32.txt
>    (revision 70146)
> +++ tools/valgrind/gtest_exclude/remoting_unittests.gtest-drmemory_win32.txt
>    (working copy)
> @@ -3,3 +3,6 @@
>  JingleSessionTest.TestEventChannel
>  JingleSessionTest.TestVideoChannel
>  JingleSessionTest.TestVideoRtpChannel
> +
> +# This test fails on an assertion, see http://crbug.com/57266
> +DecoderVp8Test.EncodeAndDecode
> Index: tools/valgrind/valgrind_test.py
> ===================================================================
> --- tools/valgrind/valgrind_test.py     (revision 70146)
> +++ tools/valgrind/valgrind_test.py     (working copy)
> @@ -754,7 +754,7 @@
>
>     proc += ["-logdir", self.temp_dir]
>     proc += ["-batch", "-quiet"]
> -    proc += ["-no_check_leaks", "-no_count_leaks"]
> +    #proc += ["-no_check_leaks", "-no_count_leaks"]
>
>     # Dr.Memory requires -- to separate tool flags from the executable name.
>     proc += ["--"]
>
>
>

Expand Messages | Collapse Messages