DOMUI: Implement the new-style Autofill options page.

chrome/browser/resources/shared/js/cr/ui/list.js

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // require: listselectionmodel.js
 
 /**
  * @fileoverview This implements a list control.
  */
 
@@ skipping 251 matching lines @@
       this.beforeFiller_ = this.ownerDocument.createElement('div');
       this.afterFiller_ = this.ownerDocument.createElement('div');
       this.beforeFiller_.className = 'spacer';
       this.afterFiller_.className = 'spacer';
       this.appendChild(this.beforeFiller_);
       this.appendChild(this.afterFiller_);
 
       var length = this.dataModel ? this.dataModel.length : 0;
       this.selectionModel = new ListSelectionModel(length);
 
+      this.addEventListener('dblclick', this.handleDoubleClick_);
       this.addEventListener('mousedown', this.handleMouseDownUp_);
       this.addEventListener('mouseup', this.handleMouseDownUp_);
       this.addEventListener('keydown', this.handleKeyDown);
       this.addEventListener('scroll', this.redraw.bind(this));
 
       // Make list focusable
       if (!this.hasAttribute('tabindex'))
         this.tabIndex = 0;
     },
 
     /**
      * Returns the height of an item, measuring it if necessary.
      * @private
      */
     getItemHeight_: function() {
       if (!this.itemHeight_)
         this.itemHeight_ = measureItem(this);
       return this.itemHeight_;
     },
 
     /**
+     * Callback for the double click event.
+     * @param {Event} e The mouse event object.
+     * @private
+     */
+    handleDoubleClick_: function(e) {
+      if (this.disabled)
+        return;
+
+      var target = e.target;
+
+      // If the target was this element we need to make sure that the user did
+      // not click on a border or a scrollbar.
+      if (target == this && !inViewport(target, e))

[arv (Not doing code reviews), 2010/12/22 18:14:07]

In this case I think you can skip this check since we are use the DOM to find
the list item and you already handle the case of no list item being clicked
below.

[James Hawkins, 2010/12/22 21:22:31]

Done.

+        return;
+
+      target = this.getListItemAncestor(target);
+
+      var index = target ? this.getIndexOfListItem(target) : -1;
+      this.activateItemAtIndex(index);

[arv (Not doing code reviews), 2010/12/22 18:14:07]

Now the question arise if we should allow Enter (and Command+Down on Mac) to
also call activateItem(s)At?

Maybe by calling this something with dblclick in it we can get around the issue.

[James Hawkins, 2010/12/22 21:22:31]

We should allow Enter to activate the item as well, I just haven't added
handling for it yet.

+    },
+
+    /**
      * Callback for mousedown and mouseup events.
      * @param {Event} e The mouse event object.
      * @private
      */
     handleMouseDownUp_: function(e) {
       if (this.disabled)
         return;
 
       var target = e.target;
 
@@ skipping 290 matching lines @@
       }
     },
   };
 
   cr.defineProperty(List, 'disabled', cr.PropertyKind.BOOL_ATTR);
 
   return {
     List: List
   }
 });