Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 6034003: Teach C++ ArraySlice builtin to deal with arguments object. (Closed)

Created:
10 years ago by antonm
Modified:
9 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Teach C++ ArraySlice builtin to deal with arguments object. Array.prototype.slice.call(arguments, ...) idiom is pretty common (up to 97% of invocations in GMail), so we'd better handle it efficiently too. Committed: http://code.google.com/p/v8/source/detail?r=6085

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -18 lines) Patch
M src/builtins.cc View 4 chunks +43 lines, -18 lines 0 comments Download
M test/mjsunit/array-slice.js View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
antonm
Anders and Mads, here comes another try. BTW, there is slight inefficiency in Array.slice (and ...
10 years ago (2010-12-20 11:52:54 UTC) #1
Mads Ager (chromium)
10 years ago (2010-12-20 13:52:57 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698