chrome/browser/ui/views/find_bar_host_win.cc - Issue 6034002: Replace Textfield::Keystroke with views::KeyEvent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/find_bar_host_win.cc

Issue 6034002: Replace Textfield::Keystroke with views::KeyEvent (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: key_code, ET_KEY_PRESS for WM_CHAR Created 9 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/find_bar_host_win.cc

diff --git a/chrome/browser/ui/views/find_bar_host_win.cc b/chrome/browser/ui/views/find_bar_host_win.cc

index 0133f609ff7e545481affa4e28fe570d3b897662..d74a8d1a8a6a20dcd579f7c63db8230d6ed9f439 100644

--- a/chrome/browser/ui/views/find_bar_host_win.cc

+++ b/chrome/browser/ui/views/find_bar_host_win.cc

@@ -26,8 +26,8 @@ void FindBarHost::GetWidgetPositionNative(gfx::Rect* avoid_overlapping_rect) {

avoid_overlapping_rect->Offset(0, webcontents_rect.top - frame_rect.top);

}

-bool FindBarHost::ShouldForwardKeystrokeToWebpageNative(

- const views::Textfield::Keystroke& key_stroke) {

+bool FindBarHost::ShouldForwardKeyEventToWebpageNative(

+ const views::KeyEvent& key_event) {

// We specifically ignore WM_CHAR. See http://crbug.com/10509.

- return key_stroke.message() == WM_KEYDOWN || key_stroke.message() == WM_KEYUP;

+ return key_event.message() == WM_KEYDOWN || key_event.message() == WM_KEYUP;

}