Chromium Code Reviews

Unified Diff: chrome/browser/ui/views/find_bar_host.h

Issue 6034002: Replace Textfield::Keystroke with views::KeyEvent (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: key_code, ET_KEY_PRESS for WM_CHAR Created 9 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « chrome/browser/ui/views/edit_search_engine_dialog.cc ('k') | chrome/browser/ui/views/find_bar_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/find_bar_host.h
diff --git a/chrome/browser/ui/views/find_bar_host.h b/chrome/browser/ui/views/find_bar_host.h
index 6ab11caa45375793fc9e54321b592def7b9629d6..997d2f80ea4c40000da6a58160bb8d087367718b 100644
--- a/chrome/browser/ui/views/find_bar_host.h
+++ b/chrome/browser/ui/views/find_bar_host.h
@@ -40,12 +40,11 @@ class FindBarHost : public DropdownBarHost,
explicit FindBarHost(BrowserView* browser_view);
virtual ~FindBarHost();
- // Forwards selected keystrokes to the renderer. This is useful to make sure
+ // Forwards selected key events to the renderer. This is useful to make sure
// that arrow keys and PageUp and PageDown result in scrolling, instead of
// being eaten because the FindBar has focus. Returns true if the keystroke
// was forwarded, false if not.
- bool MaybeForwardKeystrokeToWebpage(
- const views::Textfield::Keystroke& key_stroke);
+ bool MaybeForwardKeyEventToWebpage(const views::KeyEvent& key_event);
// FindBar implementation:
virtual FindBarController* GetFindBarController() const;
@@ -116,9 +115,9 @@ class FindBarHost : public DropdownBarHost,
// Allows implementation to tweak widget position.
void GetWidgetPositionNative(gfx::Rect* avoid_overlapping_rect);
- // Allows native implementation to prevent keystrokes from being forwarded.
- bool ShouldForwardKeystrokeToWebpageNative(
- const views::Textfield::Keystroke& key_stroke);
+ // Allows native implementation to prevent key events from being forwarded.
+ bool ShouldForwardKeyEventToWebpageNative(
+ const views::KeyEvent& key_event);
// Returns the FindBarView.
FindBarView* find_bar_view();
« no previous file with comments | « chrome/browser/ui/views/edit_search_engine_dialog.cc ('k') | chrome/browser/ui/views/find_bar_host.cc » ('j') | no next file with comments »

Powered by Google App Engine