chrome/browser/autofill/personal_data_manager.cc - Issue 6033010: Support autocompletion for HTMl5 tags:"email", "month" and "tel".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autofill/personal_data_manager.cc

Issue 6033010: Support autocompletion for HTMl5 tags:"email", "month" and "tel". (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Fix format errors and change to use toWebInputElement(). Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autofill/autofill_manager_unittest.cc ('K') | « chrome/browser/autofill/credit_card_field.cc ('k') | chrome/renderer/form_manager.cc » ('j') | chrome/renderer/form_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autofill/personal_data_manager.cc

diff --git a/chrome/browser/autofill/personal_data_manager.cc b/chrome/browser/autofill/personal_data_manager.cc

index 52b4ca7dd233d3b19e47e6e1b443c57f2a4ddb2d..7168c37cc24303342200ac0faa8ab774e346ab6a 100644

--- a/chrome/browser/autofill/personal_data_manager.cc

+++ b/chrome/browser/autofill/personal_data_manager.cc

@@ -168,8 +168,13 @@ bool PersonalDataManager::ImportFormData(

// If the user has a password set, we have no way of setting credit

// card numbers.

if (!HasPassword()) {

- imported_credit_card_->SetInfo(AutoFillType(field_type.field_type()),

- value);

+ if (LowerCaseEqualsASCII(field->form_control_type(), "month")) {

+ DCHECK_EQ(CREDIT_CARD_EXP_MONTH, field_type.field_type());

+ imported_credit_card_->SetInfoForMonthInputType(value);

+ } else {

+ imported_credit_card_->SetInfo(

+ AutoFillType(field_type.field_type()), value);

+ }

++importable_credit_card_fields;

}

} else {