Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: chrome/browser/autofill/personal_data_manager.cc

Issue 6033010: Support autocompletion for HTMl5 tags:"email", "month" and "tel". (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Add more tests, fix some format errors and change parsing. Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autofill/personal_data_manager.cc
diff --git a/chrome/browser/autofill/personal_data_manager.cc b/chrome/browser/autofill/personal_data_manager.cc
index 75f89cec002c5a7f6ad6873d590e47b60bc40b5a..b287b82d9f8864a1ff3efcd15f1f8480130908a7 100644
--- a/chrome/browser/autofill/personal_data_manager.cc
+++ b/chrome/browser/autofill/personal_data_manager.cc
@@ -168,8 +168,11 @@ bool PersonalDataManager::ImportFormData(
// If the user has a password set, we have no way of setting credit
// card numbers.
if (!HasPassword()) {
- imported_credit_card_->SetInfo(AutoFillType(field_type.field_type()),
- value);
+ if (LowerCaseEqualsASCII(field->form_control_type(), "month"))
+ imported_credit_card_->SetMonthInputInfo(value);
honten.org 2011/01/06 07:04:54 Only "month" input type, call SetMonthInputInfo().
Ilya Sherman 2011/01/07 07:28:28 It might be good to add a DCHECK here that the |fi
+ else
+ imported_credit_card_->SetInfo(
dhollowa 2011/01/07 03:47:15 nit: according to style guide we need braces {} ar
+ AutoFillType(field_type.field_type()), value);
++importable_credit_card_fields;
}
} else {

Powered by Google App Engine
This is Rietveld 408576698