Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7583)

Unified Diff: chrome/browser/autofill/autofill_manager.cc

Issue 6033010: Support autocompletion for HTMl5 tags:"email", "month" and "tel". (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autofill/autofill_manager.cc
diff --git a/chrome/browser/autofill/autofill_manager.cc b/chrome/browser/autofill/autofill_manager.cc
index 162375268776d8418d802d495793a96847dc7b5f..874ca538629fc00fdaf000edd91f1e149958928e 100644
--- a/chrome/browser/autofill/autofill_manager.cc
+++ b/chrome/browser/autofill/autofill_manager.cc
@@ -688,6 +688,12 @@ void AutoFillManager::FillCreditCardFormField(const CreditCard* credit_card,
if (field->form_control_type() == ASCIIToUTF16("select-one"))
autofill::FillSelectControl(credit_card, type, field);
+ else if (field->form_control_type() == ASCIIToUTF16("month"))
+ // THML5 input="month" consisnts of year-month.
James Hawkins 2011/01/03 19:50:00 Spelling errors in this comment.
+ field->set_value(
+ credit_card->GetFieldText(AutoFillType(CREDIT_CARD_EXP_4_DIGIT_YEAR)) +
James Hawkins 2011/01/03 19:50:00 Please extract a variable from these lines and sen
+ string16(ASCIIToUTF16("-")) +
James Hawkins 2011/01/03 19:50:00 No need to wrap with string16().
+ credit_card->GetFieldText(AutoFillType(CREDIT_CARD_EXP_MONTH)));
else
field->set_value(credit_card->GetFieldText(type));
}

Powered by Google App Engine
This is Rietveld 408576698